Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GenZToons): Removing SuryaToons - Adding GenZToons #757

Merged
merged 3 commits into from
Sep 22, 2024

Conversation

Kareylo
Copy link
Contributor

@Kareylo Kareylo commented Sep 9, 2024

As Surya Toons is now dead, I removed it.
The new Team name of Surya Toons is GenZ Toons.

Still the same template,

Checklist:

  • Updated source's version for individual source changes
  • Updated all sources' versions for template changes
  • Set appropriate nsfw value
  • Did not change id even if a source's name or language were changed
  • Tested the modifications by running it on the simulator or a test device

SuryaToons is dead, GenZ Toons is the new team name
@Kareylo
Copy link
Contributor Author

Kareylo commented Sep 9, 2024

Don't know if it would be better to just rename the labels, not the source. Could be a better choice, TBH

Copy link
Owner

@Skittyblock Skittyblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do the sources have the same content and ids? if so, it would be better to keep the old id and just change the name and bump the version. if not though, this is fine

src/rust/mangastream/sources/genztoons/res/source.json Outdated Show resolved Hide resolved
@Kareylo
Copy link
Contributor Author

Kareylo commented Sep 22, 2024

do the sources have the same content and ids? if so, it would be better to keep the old id and just change the name and bump the version. if not though, this is fine

It seems it's exactly same content and ids, I switched back to old source id and bumped the version

@Skittyblock Skittyblock merged commit cbf1730 into Skittyblock:main Sep 22, 2024
2 checks passed
@Kareylo Kareylo deleted the GenZ branch October 12, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants