-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mangademon): rewrite most of the source to account for a site remake #756
Conversation
If searching then other params just don't work, no reason to check for them and append them to the url
Co-authored-by: Skitty <[email protected]>
Co-authored-by: Skitty <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seeing a crash when opening martial peak due to duplicate chapter identifiers. double check how you're assigning chapter ids and make sure they're unique, and make sure to test on device
I've been reading from mangademon with this version of the source for a few weeks, I have 60 from it and I haven't noticed any issues. What chapter on martial peak are you having problems with, I tested a few chapters on there and they seem to work for me. |
interestingly enough, it's only happening when run on the simulator. none of the images load for me on device though. the culprit for martial peak is |
I took a look at 3705 and it seems to work on my phone even though there were chapters with that number. I just went ahead and removed duplicates anyway though |
Checklist:
nsfw
valueid
even if a source's name or language were changedCloses #753