Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comick url (from .fun to .app) #489

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Conversation

Haulien
Copy link
Contributor

@Haulien Haulien commented Oct 16, 2023

Updated comick URL in source.json from comick.fun to comick.app

Every other instance is correct, just not the one in source.json

Checklist:

  • Updated source's version for individual source changes
  • Updated all sources' versions for template changes not applicable
  • Set appropriate nsfw value not applicable
  • Did not change id even if a source's name or language were changed
  • Tested the modifications by running it on the simulator or a test device

* Updated comick URL in source.json
Copy link
Owner

@Skittyblock Skittyblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to actually change it in the code too;

const BASE_URL: &str = "https://comick.app";

@Haulien
Copy link
Contributor Author

Haulien commented Oct 20, 2023

You need to actually change it in the code too;

const BASE_URL: &str = "https://comick.app";

The code was already correct (.app), it was just the source.json that wasn't

@Skittyblock
Copy link
Owner

oh my bad I didn't even notice

@Skittyblock Skittyblock merged commit 0c194c4 into Skittyblock:main Oct 28, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants