Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ComicOnlineFree URL #479

Closed
wants to merge 9 commits into from
Closed

Update ComicOnlineFree URL #479

wants to merge 9 commits into from

Conversation

pandeynmn
Copy link
Contributor

@pandeynmn pandeynmn commented Oct 7, 2023 •
edited
Loading

Checklist:

  • Updated source's version for individual source changes
  • Updated all sources' versions for template changes
  • Set appropriate nsfw value
  • Did not change id even if a source's name or language were changed
  • Tested the modifications by running it on the simulator or a test device

fixes #478

@pandeynmn
Copy link
Contributor Author

Ready to merge

@pandeynmn
Copy link
Contributor Author

I also updated the gitignore to add all target folders to ignore as some new target files were not being ignored in wp-comics

@Skittyblock Skittyblock changed the title Update source.json Update ComicOnlineFree URL Oct 11, 2023
Skittyblock
Skittyblock requested changes Oct 11, 2023
View reviewed changes
Copy link
Owner

@Skittyblock Skittyblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you also need to update the URL in the actual source code

@medievalegg
Copy link

I hope this was the correct place to comment but this source no longer works at least under the url it currently uses.

@pandeynmn pandeynmn closed this Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skittyblock Skittyblock Skittyblock requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ComicOnlineFree URL changed. needs update
3 participants
@pandeynmn @medievalegg @Skittyblock