Add max coinbase out sigops to CoinbaseOutputDataSize #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Christopher Coverdale <[email protected]>
Start out with a single method isTestChain() that's used by the getblocktemplate RPC.
This makes the options argument for BlockAssembler constructor mandatory, dropping implicit use of ArgsManager. The caller i.e. the Mining interface implementation now handles this. In a future Stratum v2 change the Options object needs to be mofified after arguments have been processed. Specifically the pool communicates how many extra bytes it needs for its own outputs (payouts, extra commitments, etc). This will need to be substracted from what the user set as -blockmaxweight. Such a change can be implemented in createNewBlock, after ApplyArgsManOptions.
Set tip at the start of the function and only update it for a long poll. Additionally have getTipHash return an optional, so the caller can explicitly check that a tip exists.
Co-Authored-By: Christopher Coverdale <[email protected]>
Implemented starting from a copy of V2Transport and the V2TransportTester, modifying it to fit Stratum v2 and Noise Protocol requirements. Co-Authored-By: Christopher Coverdale <[email protected]> Co-Authored-By: Fi3
Co-authored-by: Vasil Dimov <[email protected]>
Co-authored-by: Christopher Coverdale <[email protected]>
Co-Authored-By: Christopher Coverdale <[email protected]>
The template provider will listen for a Job Declarator client. It can establish a connection and detect various protocol errors. Co-Authored-By: Christopher Coverdale <[email protected]> Co-Authored-By: Fi3
Stratum v2 requires pools to communicate the maximum bytes they intend to add to the coinbase outputs, as well as the maximum number of sigops. This commit adds them to BlockAssembler::Options, so they can be set later.
These defaults are needed by the Mining interface in the next commit.
Co-Authored-By: Christopher Coverdale <[email protected]>
Sjors
force-pushed
the
sv2
branch
4 times, most recently
from
7bb7ecd
to
857735e
Compare
Sjors
force-pushed
the
sv2
branch
4 times, most recently
from
f7bf25d
to
e65a074
Compare
Sjors
force-pushed
the
sv2
branch
9 times, most recently
from
44c8fa0
to
375105a
Compare
Sjors
force-pushed
the
sv2
branch
4 times, most recently
from
d0d5483
to
fe730f1
Compare
|
I'll give this a rebase after bitcoin#30440 lands. |
Sjors
force-pushed
the
sv2
branch
2 times, most recently
from
58a98ea
to
e250789
Compare
Sjors
force-pushed
the
sv2
branch
2 times, most recently
from
40f2533
to
216354f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements stratum-mining/sv2-spec#86 for the Template Provider.