(Falta Completar) Fix #9430 - Error creating a relationship with a specific characters range #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes salesagility#9430
Description
As mentioned in the issue. It exists an error creating relationships when those relationships name have between 61 and 64 characters.
In this PR we add the modification necessary to work with MySQL-MariaDB databases. We can't test it in any other.
Changes:
include/database/MysqlManager.php Line 113:
As index names will have an additional 3-5 character suffix (_idb1, etc.), set here a shorter max length for them to prevent exceeding the db supported limit of 64 chars.
modules/ModuleBuilder/parsers/relationships/AbstractRelationship.php Line 561:
The function getValidDBName() from AbstractRelationship class doesn't return correctly the shortened indexes "DBManagerFactory::getInstance()->getValidDBName()"
Motivation and Context
How To Test This
Types of changes
Final checklist