Support for Step Statistics in Ultrawide Double #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should also mention that I added a scorebox to step stats in #345 . Can you verify that the positioning/sizing is still correct (you'll need to use the launcher to check this)? |
Yup, will do! ^^ |
Roujo
force-pushed
the
step-statistics-for-double
branch
from
ae116b4
to
880e105
Compare
|
Is this PR still in progress or should I close? |
|
I haven't looked into doing the required QA in a while, but it is a feature I'd like to see in SL so I'll put that back on my plate, thank you for the reminder! 😄 (Wow, it's been 2 years, incredible 🤣) |
Roujo
force-pushed
the
step-statistics-for-double
branch
from
880e105
to
7cf2996
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of values are arbitrary and hardcoded, but this looks pretty okay.
What's missing is QA and code review. The test cases I'll have to go through are combinations of the following:
Resolutions:
Styles:
Game Modes: