add localizationTest and improve fallbackTest

Content.IntegrationTests/Tests/Parkstation/Announcers/AnnouncerFallbackTest.cs

@@ -1,3 +1,4 @@
+using System.Collections.Generic;
 using System.Linq;
 using Content.Shared.Parkstation.Announcements.Prototypes;
 using Robust.Shared.Prototypes;
@@ -6,24 +7,33 @@ namespace Content.IntegrationTests.Tests.Parkstation.Announcers;
 
 [TestFixture]
 [TestOf(typeof(AnnouncerPrototype))]
-public sealed partial class AnnouncerPrototypeTests
+public sealed class AnnouncerPrototypeTests
 {
     [Test]
     public async Task TestAnnouncerFallbacks()
     {
+        // Checks if every announcer has a fallback announcement
+
         await using var pair = await PoolManager.GetServerClient();
         var server = pair.Server;
 
         var prototype = server.ResolveDependency<IPrototypeManager>();
 
         await server.WaitAssertion(() =>
         {
+            var success = true;
+            var why = new List<string>();
+
             foreach (var announcer in prototype.EnumeratePrototypes<AnnouncerPrototype>())
             {
-                Assert.That(announcer.Announcements.Any(a => a.ID.ToLower() == "fallback"),
-                    Is.True,
-                    $"Announcer \"{announcer.ID}\" does not have a fallback announcement");
+                if (announcer.Announcements.All(a => a.ID.ToLower() != "fallback"))
+                {
+                    success = false;
+                    why.Add(announcer.ID);
+                }
             }
+
+            Assert.That(success, Is.True, $"The following announcers do not have a fallback announcement:\n  {string.Join("\n  ", why)}");
         });
 
         await pair.CleanReturnAsync();

Content.IntegrationTests/Tests/Parkstation/Announcers/AnnouncerLocalizationTest.cs

@@ -0,0 +1,66 @@
+using System.Collections.Generic;
+using Content.Server.Parkstation.Announcements.Systems;
+using Content.Server.StationEvents;
+using Content.Shared.Parkstation.Announcements.Prototypes;
+using Robust.Shared.GameObjects;
+using Robust.Shared.Localization;
+
+namespace Content.IntegrationTests.Tests.Parkstation.Announcers;
+
+[TestFixture]
+[TestOf(typeof(AnnouncerPrototype))]
+public sealed class AnnouncerLocalizationTest
+{
+    [Test]
+    public async Task TestEventLocalization()
+    {
+        // Checks if every station event wanting the announcerSystem to send messages has a localization string
+        // If an event doesn't have startAnnouncement or endAnnouncement set to true
+        //  it will be expected for that system to handle the announcements if it wants them
+
+        await using var pair = await PoolManager.GetServerClient();
+        var server = pair.Server;
+
+        var locale = server.ResolveDependency<ILocalizationManager>();
+        var entSysMan = server.ResolveDependency<IEntitySystemManager>();
+        var announcer = entSysMan.GetEntitySystem<AnnouncerSystem>();
+        var events = entSysMan.GetEntitySystem<EventManagerSystem>();
+
+        await server.WaitAssertion(() =>
+        {
+            var succeeded = true;
+            var why = new List<string>();
+
+            foreach (var ev in events.AllEvents())
+            {
+                if (ev.Value.StartAnnouncement)
+                {
+                    var announcementId = announcer.GetAnnouncementId(ev.Key.ID);
+                    var eventLocaleString = announcer.GetEventLocaleString(announcementId);
+
+                    if (locale.GetString(eventLocaleString) == eventLocaleString)
+                    {
+                        succeeded = false;
+                        why.Add($"\"{announcementId}\": \"{eventLocaleString}\"");
+                    }
+                }
+
+                if (ev.Value.EndAnnouncement)
+                {
+                    var announcementId = announcer.GetAnnouncementId(ev.Key.ID, true);
+                    var eventLocaleString = announcer.GetEventLocaleString(announcementId);
+
+                    if (locale.GetString(eventLocaleString) == eventLocaleString)
+                    {
+                        succeeded = false;
+                        why.Add($"\"{announcementId}\": \"{eventLocaleString}\"");
+                    }
+                }
+            }
+
+            Assert.That(succeeded, Is.True, $"The following announcements do not have a localization string:\n  {string.Join("\n  ", why)}");
+        });
+
+        await pair.CleanReturnAsync();
+    }
+}