Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry Pick Improvised Weaponry, DeltaV #1217

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Tmanzxd
Copy link
Contributor

@Tmanzxd Tmanzxd commented Nov 13, 2024

Description

Adds Muskets, Flintlocks, Pipebombs, Firebombs, gunpowder, and craftable ammo for flintlock weaponry from DeltaV.


TODO

  • Cherry-picked Muskets, Pipebombs, Firebombs, and Gunpowder crafting

Media

Example Media Embed


Changelog

🆑

  • add: Muskets, Flintlocks, Pipebombs, Firebombs, gunpowder, and craftable ammo for flintlock weaponry.

Tryded and others added 3 commits November 13, 2024 14:06
* Musket + parts

* Graphs for Musket and Parts

* Recipes for Musket + Sprites

* Fix 1

* Fix two

* Flintlock

* Fixes

* Fix 3.0

* null is nulled

* forgor graph

* fireRate isn't all lowercase..

* actually make ammo craftable

* Craftable Flintlock Fix

* Update improvised.yml

* Update musket.yml

* I gib up

* Make firerate 1 shot every 8 seconds and it doesn't reset when you switch hands.

* why.

* Forgor

* forgor

* Update Resources/Textures/DeltaV/Objects/Misc/bayonet.rsi/meta.json

Co-authored-by: Colin-Tel <[email protected]>
Signed-off-by: Tryded <[email protected]>

---------

Signed-off-by: Tryded <[email protected]>
Co-authored-by: Colin-Tel <[email protected]>
* Add wielded in hand sprite for musket

* actually adding the sprites in YML

* Add a missing tag
* inital

* 2-9

* add crafting function, rename ied to fire bomb

* add firebomb ignition

* fikss

* change damage values

* add note

* fix tests i think

* ok

* good

* Review

* warning

---------

Co-authored-by: metalgearsloth <[email protected]>

(cherry picked from commit 3cb1c58)
@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an RSI labels Nov 13, 2024
@SimpleStation14 SimpleStation14 changed the title Cherry pick Improvised Weaponry, DeltaV Cherry Pick Improvised Weaponry, DeltaV Nov 13, 2024
Copy link
Contributor

github-actions bot commented Nov 13, 2024

RSI Diff Bot; head commit 20f8168 merging into 74688cf
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Objects/Misc/bayonet.rsi

State Old New Status
base Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Objects/Misc/modular_breech.rsi

State Old New Status
base Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Objects/Misc/modular_trigger.rsi

State Old New Status
base Added

Resources/Textures/DeltaV/Objects/Weapons/Guns/Ammunition/Casings/musket_casing.rsi

State Old New Status
base Added

Resources/Textures/DeltaV/Objects/Weapons/Guns/Rifles/musket.rsi

State Old New Status
base Added
inhand-left Added
inhand-right Added
wielded-inhand-left Added
wielded-inhand-right Added

Resources/Textures/Objects/Weapons/Bombs/pipebomb.rsi

State Old New Status
base Added
icon Added
primed Added
wires Added

Edit: diff updated after 20f8168

@Tmanzxd
Copy link
Contributor Author

Tmanzxd commented Nov 13, 2024

Ah, Duplicate ID, my weakness

@Tmanzxd
Copy link
Contributor Author

Tmanzxd commented Nov 13, 2024

Zinga

Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun

@github-actions github-actions bot added the Status: Needs Review Someone please review this label Nov 14, 2024
@FoxxoTrystan FoxxoTrystan added Size: 3-Medium For medium issues/PRs Priority: 3-Medium Needs to be resolved at some point and removed Status: Needs Review Someone please review this labels Nov 14, 2024
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files Priority: 3-Medium Needs to be resolved at some point Size: 3-Medium For medium issues/PRs Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants