Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update medicine.yml #1210

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update medicine.yml #1210

wants to merge 1 commit into from

Conversation

Suraru
Copy link
Contributor

@Suraru Suraru commented Nov 11, 2024

Merges the med doc by floof.
At least one original change by XavierSomething (will update when other PRs are found)

Fansana/floofstation1#222

Merges the med doc by floof.
At least one original change by XavierSomething (will update when other PRs are found)

Fansana/floofstation1#222
@github-actions github-actions bot added the Changes: YML Changes any yml files label Nov 11, 2024
@Aidenkrz Aidenkrz added Priority: 5-Whenever Doesn't matter when this gets resolved Size: 5-Very Small For especially small issues/PRs Status: Needs Review Someone please review this Type: Balancing Balancing some feature Type: Port Brings something to here from another codebase Type: Bug [Un]intentional issue with something labels Nov 11, 2024
@Aidenkrz
Copy link
Contributor

The Fixes Leporazine Temperature Shock should be the only thing in this PR, rebalancing chems should be in a seperate PR.

Copy link
Member

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove Floof Comments, and mostly will need review from others maintainers regarding durk opinion.

@@ -492,12 +498,12 @@
- !type:AdjustTemperature
conditions:
- !type:Temperature
max: 293.15
max: 288.15 # Floof
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
max: 288.15 # Floof
max: 288.15

amount: 100000 # thermal energy, not temperature!
- !type:AdjustTemperature
conditions:
- !type:Temperature
min: 293.15
min: 298.15 # Floof
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
min: 298.15 # Floof
min: 298.15

@@ -1195,6 +1201,7 @@
types:
Heat: -3.0
Shock: -3.0
Cold: -3.0 # Floof
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Cold: -3.0 # Floof
Cold: -3.0

Comment on lines +227 to +229
Cellular: -4 # Floof: -2<-4
groups: # Floof
Brute: 1 # Floof
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Cellular: -4 # Floof: -2<-4
groups: # Floof
Brute: 1 # Floof
Cellular: -4
groups:
Brute: 1

@@ -211,6 +214,7 @@
physicalDesc: reagent-physical-desc-bubbling
flavor: medicine
color: "#32cd32"
worksOnTheDead: true # Floof
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
worksOnTheDead: true # Floof
worksOnTheDead: true

Comment on lines +202 to +207
Airloss: -10 # Floof: -6<-10
# Brute: -4 # Floof
# Burn: -6 # Floof
# Toxin: -4 # Floof
- !type:ModifyBloodLevel # Floof
amount: 5 # Floof
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Airloss: -10 # Floof: -6<-10
# Brute: -4 # Floof
# Burn: -6 # Floof
# Toxin: -4 # Floof
- !type:ModifyBloodLevel # Floof
amount: 5 # Floof
Airloss: -10
- !type:ModifyBloodLevel
amount: 5

@@ -181,6 +181,7 @@
physicalDesc: reagent-physical-desc-fizzy
flavor: medicine
color: "#0091ff"
worksOnTheDead: true # Floof
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
worksOnTheDead: true # Floof
worksOnTheDead: true

@FoxxoTrystan FoxxoTrystan added Status: Awaiting Changes Do not merge due to requested changes and removed Status: Needs Review Someone please review this labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files Priority: 5-Whenever Doesn't matter when this gets resolved Size: 5-Very Small For especially small issues/PRs Status: Awaiting Changes Do not merge due to requested changes Type: Balancing Balancing some feature Type: Bug [Un]intentional issue with something Type: Port Brings something to here from another codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants