-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak Whisper Display #1161
base: master
Are you sure you want to change the base?
Tweak Whisper Display #1161
Conversation
The previous description was a butchering of the English language.
|
Ok, I will try to do this and resubmit it. |
You can edit this PR instead, no need to re-submit. |
I didn't know that. |
I have edited it. *It changes the text style to italic, making it much easier to notice. This is not exactly what he requested but it is a big step in the right direction and hopefully will make his whispering experience pleasant. I could not dim the color after trying for a few hours. |
Was this actually tested? I don't believe [italic] would work as italicized fonts are seperate fonts, no? |
[italic] will override the [font] tag - so yes, it will KINDA work, but not as intended. I wish italic fonts worked via a shader or something instead of being hardcoded, but they don't. However, if we ever get language markers in any way, whether it's the way they are implemented in #1165, or some other way, that will become irrelevant. Using different fonts and colors based on the language was a questionable idea per se. |
I consider it a feature that will differentiate it even more, but if someone feels like editing it by dimming it and keeping the font the same etc. they're welcome to do it. This is just what I can do to accommodate his request to make whispering more distinguishable. |
Also, there is now have two [italic] tags nested inside one another and a [font] tag that doesn't do anything because it gets overridden. |
I will quickly remove the extra one. |
Removes redundant italics.
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Tweak Issue #1130 - Make whisper display darker and italic, mimicking Goon Station 1 as requested.
Description
Description.
TODO
Media
Changelog
🆑