-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Cool Punpun #1157
Merged
Merged
Port Cool Punpun #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEATHB4DEFEAT
added
Size: 3-Medium
For medium issues/PRs
Priority: 5-Whenever
Doesn't matter when this gets resolved
Type: Port
Brings something to here from another codebase
labels
Oct 28, 2024
github-actions
bot
added
Changes: C#
Changes any cs files
Changes: YML
Changes any yml files
labels
Oct 28, 2024
75 tasks
VMSolidus
requested changes
Oct 28, 2024
[Dependency] private readonly InventorySystem _inventory = default!; | ||
[Dependency] private readonly ServerMetaDataSystem _meta = default!; | ||
|
||
private (int, string, string, string) _punpunData = (1, string.Empty, string.Empty, string.Empty); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should really be a named struct/class
FoxxoTrystan
requested review from
a team,
Aidenkrz,
FoxxoTrystan,
Remuchi,
Peptide90,
Pspritechologist and
OldDanceJacket
and removed request for
a team
October 28, 2024 02:39
VMSolidus
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine.
Peptide90
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changes: C#
Changes any cs files
Changes: YML
Changes any yml files
Priority: 5-Whenever
Doesn't matter when this gets resolved
Size: 3-Medium
For medium issues/PRs
Status: Needs Review
Someone please review this
Type: Port
Brings something to here from another codebase
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple-Station/Parkstation#48
Simple-Station/Parkstation-Friendly-Chainsaw#2