Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Cool Punpun #1157

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Port Cool Punpun #1157

merged 4 commits into from
Nov 8, 2024

Conversation

DEATHB4DEFEAT
Copy link
Member

@DEATHB4DEFEAT DEATHB4DEFEAT commented Oct 28, 2024

@DEATHB4DEFEAT DEATHB4DEFEAT added Size: 3-Medium For medium issues/PRs Priority: 5-Whenever Doesn't matter when this gets resolved Type: Port Brings something to here from another codebase labels Oct 28, 2024
@github-actions github-actions bot added Changes: C# Changes any cs files Changes: YML Changes any yml files labels Oct 28, 2024
Content.Server/Punpun/PunpunSystem.cs Outdated Show resolved Hide resolved
Content.Server/Punpun/PunpunSystem.cs Outdated Show resolved Hide resolved
Content.Server/Punpun/PunpunComponent.cs Outdated Show resolved Hide resolved
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Oct 28, 2024
[Dependency] private readonly InventorySystem _inventory = default!;
[Dependency] private readonly ServerMetaDataSystem _meta = default!;

private (int, string, string, string) _punpunData = (1, string.Empty, string.Empty, string.Empty);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should really be a named struct/class

Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine.

@VMSolidus VMSolidus merged commit ae204a8 into Simple-Station:master Nov 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files Priority: 5-Whenever Doesn't matter when this gets resolved Size: 3-Medium For medium issues/PRs Status: Needs Review Someone please review this Type: Port Brings something to here from another codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants