React 18.3.1, bootstrap 5.3.3, @rjsf/core 5.23.1 #1847
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason we had both rmfr and rimraf. Use just rimraf's latest version.
Don't run tests with 16 any more. For example structuredClone is needed by dev tooling.
….json" (SignalK#1843) This reverts commit 8fdca1a.
serialport module has been optional, as it is platform specific and its install may fail but otherwise the server would be in working order. However when converting serialports.js to ts using import had made it a hard dependency - the server would not start without it, even if npm install had completed without errors but without serialport still installed. Use dynamic require to load it so that even if the module is missing the server starts.
…xtPoint.position value when stream source is the cmdSource. (SignalK#1844)
|
For me to be able to review this I need to be able to distinguish between changes that have already been merged, like the ts related updates, and what are the actual changes in this PR. The best way to achieve that would be to rebase this branch on master. Is this something you can do? I can assist if needed. |
|
I rebased two days ago (or at least thought I did). If there are additional steps I need to take please let me know what I need to do. |
|
Have you pushed your changes to this branch to your fork of the repository? The commit history now has a lot of commits that are already in master, they should not be there after successful rebase and force push. |
|
I pushed the changes but not force pushed.
Is it too late to force push?
And is it just a matter of executing
git push -f
…On Sun, Dec 15, 2024 at 7:05 AM Teppo Kurki ***@***.***> wrote:
Have you pushed your changes to this branch to your fork of the
repository? The commit history now has a lot of commits that are already in
master, they should not be there after successful rebase and force push.
—
Reply to this email directly, view it on GitHub
<#1847 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALTAIRDLDQ75U676Y25HCLL2FWLFHAVCNFSM6AAAAABTSUCPM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBTHEYDOMBUG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
It is safe (as long as you overwriting the repo with correct content) and yes -f will do it. |
|
Okay. Look for it soon. There's some development cruft in my commits I'd
like to remove.
FYI Pretty sure all my changes are in the packages/server-admin-ui and
server-admin-ui/dependencies directories and don't collide with
other commits.
…On Sun, Dec 15, 2024 at 8:56 AM Teppo Kurki ***@***.***> wrote:
It is safe (as long as you overwriting the repo with correct content) and
yes -f will do it.
—
Reply to this email directly, view it on GitHub
<#1847 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALTAIRGYHWTTX2JSHNLWSDD2FWYE5AVCNFSM6AAAAABTSUCPM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBTHE2DQMJSHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated with React 18.3.1, bootstrap 5.3.3 and @rjsf/core 5.23.1 support.
Issues