fix: make serialport module optional #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbender9
approved these changes
Dec 8, 2024
panaaj
approved these changes
Dec 8, 2024
serialport module has been optional, as it is platform specific and its install may fail but otherwise the server would be in working order. However when converting serialports.js to ts using import had made it a hard dependency - the server would not start without it, even if npm install had completed without errors but without serialport still installed. Use dynamic require to load it so that even if the module is missing the server starts.
tkurki
force-pushed
the
fix-make-serialport-optional
branch
from
f451cea to
bf35d33
Compare
naugehyde
pushed a commit
to naugehyde/signalk-server-nextgen
that referenced
this pull request
Dec 14, 2024
serialport module has been optional, as it is platform specific and its install may fail but otherwise the server would be in working order. However when converting serialports.js to ts using import had made it a hard dependency - the server would not start without it, even if npm install had completed without errors but without serialport still installed. Use dynamic require to load it so that even if the module is missing the server starts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serialport module has been optional, as it is platform specific and its install may fail but otherwise the server would be in working order.
However when converting serialports.js to ts using import had made it a hard dependency - the server would not start without it, even if npm install had completed without errors but without serialport still installed.
Use dynamic require to load it so that even if the module is missing the server starts.