Only send stop_at_ratio and stop_ratio when ratio != -1 for deluge based clients

[destotelhorus]

Only send stop_at_ratio and stop_ratio when ratio != -1 for deluge based clients.

Fixes:

• -1 currently not behaving as disabled "stop on ratio" in deluge clients.

• PR is based on the DEVELOP branch

• Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review

• Read contribution guide

Summary by CodeRabbit

• Bug Fixes
  • Improved ratio handling in Deluge clients by adding a check to prevent updates when the ratio is set to -1.0.

[coderabbitai]

Walkthrough

The update introduces a conditional check in the make_options function within the __deluge_base.py script of the SickChill project. This new condition evaluates whether the result.ratio is different from -1.0 before proceeding to update options that are associated with ratio handling. This adjustment ensures that ratio-related options are only modified under specific circumstances, enhancing the functionality's precision.

Changes

File	Summary
.../clients/__deluge_base.py	Added a condition to check result.ratio != -1.0 before updating ratio-related options.

🐰✨
In the land of code and dew,
A rabbit tweaked the logic true.
"If ratio's not minus one," it said,
Then let the options forge ahead.
With every hop and every leap,
Our code grows strong, our bounds we keep.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between be6bd68 and 893b9e4.

Files selected for processing (1)

• sickchill/oldbeard/clients/__deluge_base.py (1 hunks)

[BKSteve]

The bot is just a bot. It doesn't change your code, only suggestions.
If it's talking bs then just ignore and mark its comments as resolved.

[miigotu]

Two things,
You'll have to remove the spaces inside the parentheses or more preferably remove the parentheses around the check for != -1.0

Also, why not check that and float(result.ratio) >= 0.0 so -0.9 doesn't work

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 893b9e4 and f9dbf8a.

Files selected for processing (1)

• sickchill/oldbeard/clients/__deluge_base.py (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• sickchill/oldbeard/clients/__deluge_base.py

[github-actions]

This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.