Ignore ModelMultipleChoiceField in Form::fill method 🐋

Sibyx · Oct 29, 2020 · db63fa3 · db63fa3
1 parent 2552a33
commit db63fa3
Show file tree

Hide file tree

Showing 5 changed files with 113 additions and 106 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.16.1 : 29.10.2020
+
+- **Fix**: Ignore `ModelMultipleChoiceField` in `Form::fill()`
+
 ## 0.16.0 : 14.09.2020
 
 - **Change**: Correctly resolve key postfix if `ModelChoiceField` is used in `Form::fill()`

diff --git a/django_api_forms/forms.py b/django_api_forms/forms.py
@@ -3,7 +3,7 @@
 from typing import Union, List
 
 from django.core.exceptions import NON_FIELD_ERRORS, ValidationError
-from django.forms import ModelChoiceField
+from django.forms import ModelChoiceField, ModelMultipleChoiceField
 from django.forms.forms import DeclarativeFieldsMetaclass
 from django.utils.translation import gettext as _
 
@@ -190,6 +190,10 @@ def fill(self, obj, exclude: List[str] = None):
             if hasattr(field, 'ignore_fill') and field.ignore_fill:
                 continue
 
+            # ModelMultipleChoiceField is not fillable too (yet)
+            if isinstance(field, ModelMultipleChoiceField):
+                continue
+
             """
             We need to changes key postfix if there is ModelChoiceField (because of _id etc.)
             We always try to assign whole object instance, for example:

diff --git a/django_api_forms/version.py b/django_api_forms/version.py
@@ -1 +1 @@
-__version__ = '0.16.0'
+__version__ = '0.16.1'