-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(explorer-e2e): adjust address amount test #812
base: main
Are you sure you want to change the base?
refactor(explorer-e2e): adjust address amount test #812
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @telestrial and the rest of your teammates on Graphite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does removing this value do?
This test was failing because there's some rounding inconsistency here that I don't completely understand. I don't believe it comes from any adjustments I've made. The rendered amount was flipping between 1.262 and 1.261 MS. I do think it's probably worth it to create a task to investigate but I'm not sure it's worth it to pin the success of this test on. Definitely willing to defer to your wisdom on that, though! |
Interesting, I don't see why the value would change, can you consistently recreate the flipping when you run the test locally? |
056b87d
to
4a6598e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interested to investigate why the number would be changing, but do merge if it stabilizes the tests while the focus is elsewhere.
Taking a gander at this some more, I was wrong about my assumption that it was a rounding issue. I think it is that this address is being "spent down" from when I first wrote the test. That's a good reason not to try to test this value--that it's going to change over time. |
No description provided.