Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(explorer-e2e): adjust address amount test #812

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

telestrial
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 8:41pm
explorer-zen ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 8:41pm
hostd ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 8:41pm
renterd ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 8:41pm
website ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 8:41pm

Copy link

changeset-bot bot commented Nov 13, 2024

⚠️ No Changeset found

Latest commit: 4a6598e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor Author

telestrial commented Nov 13, 2024

Copy link
Member

@alexfreska alexfreska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does removing this value do?

Copy link
Contributor Author

This test was failing because there's some rounding inconsistency here that I don't completely understand. I don't believe it comes from any adjustments I've made. The rendered amount was flipping between 1.262 and 1.261 MS. I do think it's probably worth it to create a task to investigate but I'm not sure it's worth it to pin the success of this test on. Definitely willing to defer to your wisdom on that, though!

Copy link
Member

Interesting, I don't see why the value would change, can you consistently recreate the flipping when you run the test locally?

@telestrial telestrial force-pushed the 11-13-refactor_explorer-e2e_adjust_address_amount_test branch from 056b87d to 4a6598e Compare November 13, 2024 20:40
@telestrial telestrial changed the base branch from 11-13-refactor_explored-types_add_outputid_to_explorerfilecontract to main November 13, 2024 20:40
@alexfreska alexfreska self-requested a review November 13, 2024 22:04
Copy link
Member

@alexfreska alexfreska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interested to investigate why the number would be changing, but do merge if it stabilizes the tests while the focus is elsewhere.

Copy link
Contributor Author

Taking a gander at this some more, I was wrong about my assumption that it was a rounding issue. I think it is that this address is being "spent down" from when I first wrote the test. That's a good reason not to try to test this value--that it's going to change over time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants