Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: renterd price pinning related library changes #673

Merged
merged 1 commit into from
Aug 9, 2024
Merged

feat: renterd price pinning related library changes #673

merged 1 commit into from
Aug 9, 2024

Conversation

alexfreska
Copy link
Member

@alexfreska alexfreska commented Jul 29, 2024 •
edited
Loading

  • Variety of design-system changes required for price pinning and configuration features.
  • Move some common unit conversion methods to shared library and add basic tests.

Changes

  • Added font and tipSide props to ValueFiat. Component also now uses existing extendedSuffix prop.
  • Added font and tipSide props to ValueScFiat.
  • Added an objectEntries method, a typesafe Object.entries.
  • FieldFiat input is now a unified control with focus and other states including both the input and read-only siacoin value.
  • Renamed toFixMax and added BigNumber and Number variants.
  • Added font prop to ValueSc.
  • Added a TipText.
  • Added an autoVisibility prop to ConfigurationPanelSetting.
  • Form configuration tips now follow currency display settings.
  • Slightly widened the width of form configuration fields.
  • Form field inputs no longer trigger setValue on blur.
  • Added ellipsis prop to Code.
  • Added formSetField and formSetFields convenience methods for working with ConfigFields form data.
  • The ConfigField type now supports a custom suggestionLabel property.

@vercel Vercel
Copy link

vercel bot commented Jul 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 3:01pm
explorer-zen ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 3:01pm
hostd ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 3:01pm
renterd ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 3:01pm
walletd ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 3:01pm
website ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 3:01pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 29, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 7195415

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@siafoundation/design-system Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexfreska alexfreska mentioned this pull request Jul 29, 2024
Merged
@alexfreska Graphite App
Copy link
Member Author

alexfreska commented Jul 29, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alexfreska and the rest of your teammates on Graphite Graphite

@alexfreska alexfreska mentioned this pull request Jul 29, 2024
Merged
@alexfreska alexfreska force-pushed the feat_renterd_price_pinning_api branch from 3161264 to cb2189e Compare July 29, 2024 13:46
@alexfreska alexfreska force-pushed the feat_renterd_price_pinning_lib branch from f0fa37a to eafc6a1 Compare July 29, 2024 13:46
@alexfreska alexfreska force-pushed the feat_renterd_price_pinning_api branch from cb2189e to bd28499 Compare July 29, 2024 13:51
@alexfreska alexfreska force-pushed the feat_renterd_price_pinning_lib branch 5 times, most recently from 404d57d to ad7d757 Compare July 30, 2024 19:18
@alexfreska alexfreska force-pushed the feat_renterd_price_pinning_api branch from bd28499 to ad715cb Compare August 2, 2024 16:36
@alexfreska alexfreska force-pushed the feat_renterd_price_pinning_lib branch from ad7d757 to 1e70e8d Compare August 2, 2024 16:37
@alexfreska alexfreska force-pushed the feat_renterd_price_pinning_api branch from ad715cb to 951a644 Compare August 2, 2024 21:01
@alexfreska alexfreska force-pushed the feat_renterd_price_pinning_lib branch 2 times, most recently from e8b1c2f to 4d88b90 Compare August 5, 2024 23:30
@alexfreska alexfreska marked this pull request as ready for review August 6, 2024 01:03
@alexfreska alexfreska force-pushed the feat_renterd_price_pinning_api branch from 951a644 to 37b6ea2 Compare August 6, 2024 01:07
@alexfreska alexfreska force-pushed the feat_renterd_price_pinning_lib branch from 4d88b90 to e46c8e5 Compare August 6, 2024 01:07
@alexfreska Graphite App
Copy link
Member Author

alexfreska commented Aug 9, 2024 •
edited
Loading

Merge activity

  • Aug 9, 10:59 AM EDT: @alexfreska started a stack merge that includes this pull request via Graphite.
  • Aug 9, 11:01 AM EDT: Graphite rebased this pull request as part of a merge.
  • Aug 9, 11:02 AM EDT: @alexfreska merged this pull request with Graphite.

@alexfreska alexfreska changed the base branch from feat_renterd_price_pinning_api to graphite-base/673 August 9, 2024 14:59
@alexfreska alexfreska changed the base branch from graphite-base/673 to main August 9, 2024 14:59
@alexfreska alexfreska force-pushed the feat_renterd_price_pinning_lib branch from e46c8e5 to 7195415 Compare August 9, 2024 15:00
@alexfreska alexfreska merged commit 6ad3f2f into main Aug 9, 2024
17 of 19 checks passed
@alexfreska alexfreska deleted the feat_renterd_price_pinning_lib branch August 9, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisSchinnerl ChrisSchinnerl ChrisSchinnerl approved these changes

Assignees

@alexfreska alexfreska

Labels
None yet
Projects
Sia
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexfreska @ChrisSchinnerl