Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add net address and uptime to node profile #487

Merged
merged 2 commits into from
Feb 16, 2024
Merged

add net address and uptime to node profile #487

merged 2 commits into from
Feb 16, 2024

Conversation

alexfreska
Copy link
Member

@alexfreska alexfreska commented Feb 14, 2024

  • The renterd and hostd node profile details now include uptime.
Screenshot 2024-02-14 at 2 54 54 PM

Copy link

changeset-bot bot commented Feb 14, 2024

🦋 Changeset detected

Latest commit: c98f194

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siafoundation/units Minor
renterd Minor
hostd Minor
@siafoundation/design-system Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@n8maninger
Copy link
Member

Net address doesn’t really make sense for renterd imo

Copy link
Member

@ChrisSchinnerl ChrisSchinnerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Nate. NetAdress doesn't make sense for renters imo.

@alexfreska
Copy link
Member Author

@n8maninger @ChrisSchinnerl yeah hmm, I guess that change was mainly for me or others who use the hosted UI with multiple nodes - I was just getting confused as to which node I was looking at. I think hostd has a config value for "name", does renterd have this? I could simply show the name, if set.

@ChrisSchinnerl
Copy link
Member

@alexfreska The bus doesn't have a name but the worker api got a /id endpoint that exposes a name that you can give your worker to distinguish between them in a cluster setup.

feat: hostd node profile uptime
@alexfreska
Copy link
Member Author

@ChrisSchinnerl @n8maninger I've removed the net address, this is now just uptime.

@n8maninger n8maninger merged commit ce05740 into main Feb 16, 2024
1 check passed
@n8maninger n8maninger deleted the profile branch February 16, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants