Implement Deserialize for PublicKey, Algorithm, UnlockConditions, SiacoinOutputID, SiacoinInputID, SiacoinOutput, SiacoinInput, SiafundOutput and SiafundInput
#32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
ChrisSchinnerl
force-pushed
the
chris/deserialize-common
branch
from
4784519
to
430df13
Compare
ChrisSchinnerl
force-pushed
the
chris/deserialize-common
branch
from
f29008a
to
0a692e8
Compare
ChrisSchinnerl
commented
Jul 10, 2024
|
|
||
| /// An ed25519 public key that can be used to verify a signature | ||
| #[derive(Debug, PartialEq, Clone, Copy)] | ||
| pub struct PublicKey([u8; 32]); | ||
|
|
||
| impl PublicKey { | ||
| const PREFIX: &'static str = "ed25519:"; |
There was a problem hiding this comment.
I'd like to draw some attention to this. Strictly speaking types.PublicKey in core adds this prefix when json marshaling. Unfortunately though, UnlockKey with specifier ed25519 doesn't serialize the same as PublicKey so UnlockKey can't replace PublicKey.
ChrisSchinnerl
force-pushed
the
chris/deserialize-common
branch
from
0a692e8
to
3fc34a5
Compare
ChrisSchinnerl
force-pushed
the
chris/deserialize-common
branch
from
3fc34a5
to
676cbe7
Compare
ChrisSchinnerl
changed the title
SiacoinOutput and SiacoinInputPublicKey, UnlockKey, Algorithm, SiacoinOutput and SiacoinInput
ChrisSchinnerl
changed the title
PublicKey, UnlockKey, Algorithm, SiacoinOutput and SiacoinInputPublicKey, Algorithm, UnlockConditions, SiacoinOutput and SiacoinInput
ChrisSchinnerl
force-pushed
the
chris/deserialize-common
branch
from
b528873
to
3ca744a
Compare
ChrisSchinnerl
changed the title
PublicKey, Algorithm, UnlockConditions, SiacoinOutput and SiacoinInputPublicKey, Algorithm, UnlockConditions, SiacoinOutput, SiacoinInput, SiafundOutput and SiafundInput
ChrisSchinnerl
commented
Jul 10, 2024
| @@ -31,9 +31,9 @@ pub struct Hash256([u8; 32]); | |||
| impl Serialize for Hash256 { | |||
| fn serialize<S: serde::Serializer>(&self, serializer: S) -> Result<S::Ok, S::Error> { | |||
| if serializer.is_human_readable() { | |||
| serializer.serialize_str(&self.to_string()) | |||
| String::serialize(&self.to_string(), serializer) | |||
There was a problem hiding this comment.
FYI: these renames are for consistency rather than functionality. In theory &self.to_string().serialize(&serializer) might also work but specifying the intended type first and then calling serialize on it seemed like the most readable option to me.
ChrisSchinnerl
changed the title
PublicKey, Algorithm, UnlockConditions, SiacoinOutput, SiacoinInput, SiafundOutput and SiafundInputPublicKey, Algorithm, UnlockConditions, SiacoinOutputID, SiacoinInputID, SiacoinOutput, SiacoinInput, SiafundOutput and SiafundInput
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a test that verifies both the binary and json encoding against actual output from
core.