Isolate uploader in separate package #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisSchinnerl
changed the base branch from
dev
to
chris/simplify-sector-cache
ChrisSchinnerl
force-pushed
the
chris/isolate-uploader
branch
from
2817d62
to
6dde909
Compare
ChrisSchinnerl
force-pushed
the
chris/isolate-uploader
branch
from
6dde909
to
f955e41
Compare
ChrisSchinnerl
force-pushed
the
chris/isolate-uploader
branch
from
f955e41
to
6d91c0d
Compare
peterjan
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next step towards moving the upload manager to a separate package. This breaks out the
Uploadersince it was slightly too tight with the manager.The next step will be for the manager to move out of the worker