Add usability column to contracts table
#1660
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjan
commented
Nov 8, 2024
stores/sql/sqlite/migrations/main/migration_00027_contract_usability.sql
Outdated
Show resolved
Hide resolved
peterjan
force-pushed
the
pj/contract-usability
branch
from
654f588
to
36b6ca4
Compare
peterjan
force-pushed
the
pj/contract-usability
branch
from
36b6ca4
to
7f2d604
Compare
stores/sql/mysql/migrations/main/migration_00027_contract_usability.sql
Outdated
Show resolved
Hide resolved
stores/sql/sqlite/migrations/main/migration_00027_contract_usability.sql
Show resolved
Hide resolved
stores/sql/sqlite/migrations/main/migration_00027_contract_usability.sql
Show resolved
Hide resolved
tested migrations on SQLite and MySQL, scratch databases though but with an entry in the contracts table, seems OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
usabilitycolumn to thecontractstable. This is the first in a series of PRs that removes the notion of a contract set and replaces it with an indication the contract is good for renewal and thus can be used for uploading and downloading. It's an enum to ensure we can extend it without requiring a migration.This PR essentially introduces an unused field called
usability. Removingcontract_setsis slightly more involved than I thought it would be. Mostly because of slabs, buffered slabs and the whole health mechanism. I plan on removing it in 3-4 PRs.