Move memory manager from worker to dedicated package #1651
Merged
+32
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisSchinnerl
changed the title
ChrisSchinnerl
force-pushed
the
chris/isolate-memory
branch
2 times, most recently
from
e6d1b8e
to
b22253e
Compare
peterjan
approved these changes
Nov 6, 2024
ChrisSchinnerl
force-pushed
the
chris/isolate-memory
branch
from
b22253e
to
2196367
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the multiple steps required to merge the autopilot + migrations into the bus.
With both the worker and autopilot requiring the ability to upload, we need to isolate the upload manager.
To do that we need to isolate shared dependencies between upload and download manager.
Trying to achieve this in the smallest possible bites, I'm starting with the memory manager.