Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add purchase options card extensions #2387

Open
wants to merge 5 commits into
base: unstable
Choose a base branch
from

Conversation

JulienHe
Copy link

@JulienHe JulienHe commented Sep 30, 2024

Background

Closes https://github.com/Shopify/subscriptions-app-remix/issues/1642, shipping for 2025-01, but will make it on unstable mid-october

Adding the UI extension action for the purchase options card in the product page and product variant page.
The extension target are named:

  • admin.product-purchase-option.action.render
  • admin.product-variant-purchase-option.action.render

This should be release as the same as we are releasing our new extensions by enabling our beta flag.

We do also have a PR for the documentation of these targets.
This PR add the related documentations on Shopify-dev

🎩

Checklist

  • I have 🎩'd these changes
  • I have updated relevant documentation

Copy link
Contributor

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset directory. If the changes are user-facing and should cause a version bump, run yarn changeset to track your changes and include them in the next release CHANGELOG. If you are making simple updates to repo configuration, examples, or documentation, you do not need to add a changeset.

@JulienHe JulienHe marked this pull request as draft September 30, 2024 14:06

export interface PurchaseOptionsCardConfigurationApi<
ExtensionTarget extends AnyExtensionTarget,
> extends StandardApi<ExtensionTarget> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you will want to extend ActionExtensionApi here, or just add the close method from that type (I forget if extends can override a property, in this case data.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, changed.

Copy link
Member

@vividviolet vividviolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have to wait to merge this until the 2024-10 branch has been created

@JulienHe
Copy link
Author

I think we have to wait to merge this until the 2024-10 branch has been created

Yes

@JulienHe JulienHe force-pushed the jhe-purchase-options-extensions branch from c597ccb to e8eb8ba Compare September 30, 2024 16:42
@JulienHe JulienHe marked this pull request as ready for review September 30, 2024 17:57

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: should we show a puzzlify header to match the other screenshots in this page?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will change that 👍

@paulomarg
Copy link

From our perspective, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants