Do not pin minimum patch version in module #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abecevello
approved these changes
Oct 16, 2024
|
@jaimem88 Thanks for catching this mistake. I'll merge this PR and get a new version released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying the patch version in the Go module means that any other modules using this need to comply. This has caused our
go.modfile to change. While is not necessarily bad, we only use this library for testing so it feels wrong to have to pin our own version to match this module.By only specifying the major+minor version in the
go.modfile, we let the Go toolchain pick the appropriate version that is available when building the binary but requiring at least the1.22version.