Support Bundler 2.6.1 #2129
Open
Support Bundler 2.6.1 #2129
+25
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gem::Specification.stubs used to be a `Bundler::SpecSet` when `bundler/setup` has been required. However, that was unintentional and was reverted to be a plain array of specs like with standard RubyGems in Bundler 2.5.23. This change make specs support that change.
RubyGems 3.5.x ships with Bundler 2.5.x, so it's unnecessary.
In CI, we bump to RubyGems 3.5.23 which ships with Bundler 2.5.23.
Bundler 2.6 made a change where missing_specs are now kept in the original resolve spec set, not in the spec set with materialized specifications. This change adapts tapioca to that.
deivid-rodriguez
force-pushed
the
bundler-fixes
branch
from
dae7d98 to
a41dc1c
Compare
4 tasks
KaanOzkan
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Thanks! Opened sorbet/sorbet#8394 to resolve the type checking error.
| @@ -45,6 +45,9 @@ jobs: | |||
| experimental: true | |||
| - ruby: "head" | |||
| experimental: true | |||
| - rails: "current" | |||
| ruby: "3.3" | |||
| rubygems: "3.5.23" | |||
There was a problem hiding this comment.
Curious, any particular reason you picked Ruby 3.3 for this?
There was a problem hiding this comment.
No, not really. I wanted to keep at least one job running with older Bundler, and I chose the latest released Ruby but there was no particular reason, we could also choose the oldest supported Ruby, for example.
5 tasks
|
I'm also adding a basic tapioca check to our CI: rubygems/rubygems#8346. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Bundler 2.6 has just been released and unfortunately I noticed that it does not play well with tapioca.
Implementation
The main incompatibility I noticed was introduced at rubygems/rubygems#8251.
In that PR, missing specs were moved from the spec set of materialized specifications to the spec set holding the original resolution.
Unfortunately, that's necessary to fix the issue I wanted to solve, and I'm not sure how to fix the original issue while making the change backwards compatible with what tapioca was doing here. So I'm trying to change tapioca instead to play nice with Bundler 2.6.
I also found another test only incompatibility introduced by rubygems/rubygems#8165 in Bundler 2.5.23. That's because
Gem::Specification.stubswould hold aBundler::SpecSetbefore that PR (similar to a hash) while after the PR it was change to hold an array of specs (the same thing it holds whenbundler/setuphas not been loaded). Since this only affects specs, I changed the specs to play nice with that change as well.Tests
My hope is to run CI with the latest Bundler and get tests green.
I'm also planning to introduce a basic tapioca CLI check to Bundler's CI so that I can detect this issue in advance in the future.