-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix infinite recursion bug in .inherited
sigs
#1636
Open
amomchilov
wants to merge
2
commits into
main
Choose a base branch
from
bug/GenericTypeRegistry-recursion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+57
−6
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -77,6 +77,19 @@ class GenericTypeRegistrySpec < Minitest::Spec | |
refute_same(result, RaisesInInheritedCallback) | ||
assert_operator(result, :<, RaisesInInheritedCallback) | ||
end | ||
|
||
it "works for classes that specify a 'loose' sig on .inherited" do | ||
# By "loose", we mean `T::Class[T.anything]` instead of `T::Class[SampleGenericClass[T.anything]]` | ||
_ = HasNonRecursiveInheritedSig[Object] | ||
end | ||
|
||
it "FIXME: breaks from infinite recursion if the sig on .inherited uses the generic type" do | ||
# Our swizzled implementation of the `.inherited` method needs to be carefully implemented to not fall into | ||
# infinite recursion when the sig for the method references the class that it's defined on. | ||
assert_raises(SystemStackError) do | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's try to not commit code that is being changed by a commit in the same PR. You can introduce a test that breaks, and fix it in the next commit, TDD like. |
||
HasRecursiveInheritedSig[Object] | ||
end | ||
end | ||
end | ||
end | ||
|
||
|
@@ -98,6 +111,39 @@ def inherited(subclass) | |
end | ||
end | ||
end | ||
|
||
class HasNonRecursiveInheritedSig | ||
extend T::Generic | ||
|
||
Element = type_member | ||
|
||
class << self | ||
extend T::Sig | ||
|
||
# The correct type would be `T::Class[SampleGenericClass[T.anything]]`, but that would crash Tapioca. | ||
# That's not honey Pooh, that's recursion! | ||
sig { params(subclass: T::Class[T.anything]).void } | ||
def inherited(subclass) | ||
super | ||
end | ||
end | ||
end | ||
|
||
class HasRecursiveInheritedSig | ||
extend T::Generic | ||
|
||
Element = type_member | ||
|
||
class << self | ||
extend T::Sig | ||
|
||
# This sig references an instantiation of this class itself. | ||
sig { params(subclass: T::Class[HasRecursiveInheritedSig[T.anything]]).void } | ||
def inherited(subclass) | ||
super | ||
end | ||
end | ||
end | ||
end | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ There is a typo in the commit message