Fix symbol location for hash, keyword argument keys #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the symbol is used as `a: 1`, the location should not include the colon.
amomchilov
approved these changes
Jan 7, 2025
| "testdata/namer/type_alias.rb", | ||
| "testdata/namer/type_member_inside_method.rb", | ||
| "testdata/namer/type_template_inside_method.rb", | ||
| "testdata/deviations/keyword_method_names.rb", |
There was a problem hiding this comment.
Not really. We don't test against deviations tests atm and this one has syntax error so falls into the category that we don't plan to deal with now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When the symbol is used as
a: 1, the location should not include the colon.Closes #388
Closes #378
Closes #377
Closes #374
Closes #371
Closes #367
I also found that after this PR, we can run and pass ALL non-error-related Sorbet tests 😄
Test plan
See included automated tests.