Bump rubocop from 1.63.4 to 1.71.0

Gemfile.lock

@@ -2,7 +2,7 @@ PATH
   remote: .
   specs:
     rubocop-shopify (2.15.1)
-      rubocop (~> 1.51)
+      rubocop (~> 1.71)
 
 GEM
   remote: https://rubygems.org/
@@ -12,12 +12,12 @@ GEM
     byebug (11.1.3)
     coderay (1.1.3)
     diffy (3.4.3)
-    json (2.7.2)
+    json (2.9.1)
     language_server-protocol (3.17.0.3)
     method_source (1.0.0)
     minitest (5.25.4)
-    parallel (1.24.0)
-    parser (3.3.1.0)
+    parallel (1.26.3)
+    parser (3.3.7.0)
       ast (~> 2.4.1)
       racc
     pry (0.14.2)
@@ -26,26 +26,26 @@ GEM
     pry-byebug (3.10.1)
       byebug (~> 11.0)
       pry (>= 0.13, < 0.15)
-    racc (1.7.3)
+    racc (1.8.1)
     rainbow (3.1.1)
     rake (13.2.1)
-    regexp_parser (2.9.0)
-    rexml (3.2.6)
-    rubocop (1.63.4)
+    regexp_parser (2.10.0)
+    rubocop (1.71.0)
       json (~> 2.3)
       language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8, < 3.0)
-      rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.31.1, < 2.0)
+      regexp_parser (>= 2.9.3, < 3.0)
+      rubocop-ast (>= 1.36.2, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.31.3)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.37.0)
       parser (>= 3.3.1.0)
     ruby-progressbar (1.13.0)
-    unicode-display_width (2.5.0)
+    unicode-display_width (3.1.4)
+      unicode-emoji (~> 4.0, >= 4.0.4)
+    unicode-emoji (4.0.4)
 
 PLATFORMS
   ruby

rubocop-shopify.gemspec

@@ -23,5 +23,5 @@ Gem::Specification.new do |s|
 
   s.required_ruby_version = ">= 3.0.0"
 
-  s.add_dependency("rubocop", "~> 1.51")
+  s.add_dependency("rubocop", "~> 1.71")
 end

rubocop.yml

@@ -10,12 +10,15 @@ inherit_mode:
   - Include
 
 AllCops:
-  StyleGuideBaseURL: https://shopify.github.io/ruby-style-guide/
   NewCops: disable # New cops will be triaged by style guide maintainers instead.
+  StyleGuideBaseURL: https://shopify.github.io/ruby-style-guide/
 
 Bundler/OrderedGems:
   Enabled: false
 
+Gemspec/AddRuntimeDependency:
+  Enabled: true
+
 Gemspec/DeprecatedAttributeAssignment:
   Enabled: true
 
@@ -44,8 +47,8 @@ Layout/FirstArrayElementIndentation:
   EnforcedStyle: consistent
 
 Layout/FirstArrayElementLineBreak:
-  Enabled: true
   AllowMultilineFinalElement: true
+  Enabled: true
 
 Layout/FirstHashElementIndentation:
   EnforcedStyle: consistent
@@ -54,8 +57,8 @@ Layout/FirstHashElementLineBreak:
   Enabled: true
 
 Layout/FirstMethodArgumentLineBreak:
-  Enabled: true
   AllowMultilineFinalElement: true
+  Enabled: true
 
 Layout/HashAlignment:
   EnforcedLastArgumentHashStyle: ignore_implicit
@@ -76,15 +79,15 @@ Layout/LineLength:
   - "\\A\\s*def test_\\w+\\s*\\Z"
 
 Layout/MultilineArrayLineBreaks:
-  Enabled: true
   AllowMultilineFinalElement: true
+  Enabled: true
 
 Layout/MultilineHashKeyLineBreaks:
   Enabled: true
 
 Layout/MultilineMethodArgumentLineBreaks:
-  Enabled: true
   AllowMultilineFinalElement: true
+  Enabled: true
 
 Layout/MultilineMethodCallIndentation:
   EnforcedStyle: indented
@@ -111,6 +114,9 @@ Lint/AmbiguousOperatorPrecedence:
 Lint/AmbiguousRange:
   Enabled: false
 
+Lint/ArrayLiteralInRegexp:
+  Enabled: true
+
 Lint/BooleanSymbol:
   Enabled: false
 
@@ -120,6 +126,9 @@ Lint/ConstantDefinitionInBlock:
 Lint/ConstantOverwrittenInRescue:
   Enabled: true
 
+Lint/ConstantReassignment:
+  Enabled: true
+
 Lint/DeprecatedConstants:
   Enabled: false
 
@@ -150,6 +159,9 @@ Lint/DuplicateRequire:
 Lint/DuplicateRescueException:
   Enabled: false
 
+Lint/DuplicateSetElement:
+  Enabled: true
+
 Lint/EmptyBlock:
   Enabled: false
 
@@ -180,6 +192,9 @@ Lint/FloatComparison:
 Lint/HashCompareByIdentity:
   Enabled: false
 
+Lint/HashNewWithKeywordArgumentsAsDefault:
+  Enabled: true
+
 Lint/IdentityComparison:
   Enabled: false
 
@@ -228,6 +243,9 @@ Lint/NonDeterministicRequireOrder:
 Lint/NumberedParameterAssignment:
   Enabled: false
 
+Lint/NumericOperationWithConstantResult:
+  Enabled: true
+
 Lint/OrAssignmentToConstant:
   Enabled: false
 
@@ -296,6 +314,9 @@ Lint/ShadowedArgument:
 Lint/ShadowingOuterLocalVariable:
   Enabled: false
 
+Lint/SharedMutableDefault:
+  Enabled: true
+
 Lint/StructNewOverride:
   Enabled: false
 
@@ -317,6 +338,9 @@ Lint/TrailingCommaInAttributeDeclaration:
 Lint/TripleQuotes:
   Enabled: false
 
+Lint/UnescapedBracketInRegexp:
+  Enabled: true
+
 Lint/UnexpectedBlockArity:
   Enabled: false
 
@@ -335,9 +359,15 @@ Lint/UriEscapeUnescape:
 Lint/UriRegexp:
   Enabled: false
 
+Lint/UselessDefined:
+  Enabled: true
+
 Lint/UselessMethodDefinition:
   Enabled: false
 
+Lint/UselessNumericOperation:
+  Enabled: true
+
 Lint/UselessRescue:
   Enabled: true
 
@@ -400,10 +430,10 @@ Naming/MethodParameterName:
   Enabled: false
 
 Naming/PredicateName:
-  NamePrefix:
-  - is_
   ForbiddenPrefixes:
   - is_
+  NamePrefix:
+  - is_
 
 Naming/RescuedExceptionsVariableName:
   Enabled: false
@@ -432,6 +462,9 @@ Style/AccessorGrouping:
 Style/Alias:
   EnforcedStyle: prefer_alias_method
 
+Style/AmbiguousEndlessMethodDefinition:
+  Enabled: true
+
 Style/ArgumentsForwarding:
   Enabled: false
 
@@ -441,6 +474,9 @@ Style/ArrayIntersect:
 Style/BisectedAttrAccessor:
   Enabled: false
 
+Style/BitwisePredicate:
+  Enabled: true
+
 Style/CaseEquality:
   AllowOnConstant: true
   AllowOnSelfClass: true
@@ -452,15 +488,18 @@ Style/ClassEqualityComparison:
   Enabled: false
 
 Style/ClassMethodsDefinitions:
-  EnforcedStyle: self_class
   Enabled: true
+  EnforcedStyle: self_class
 
 Style/CollectionCompact:
   Enabled: false
 
 Style/ColonMethodDefinition:
   Enabled: false
 
+Style/CombinableDefined:
+  Enabled: true
+
 Style/CombinableLoops:
   Enabled: false
 
@@ -482,6 +521,9 @@ Style/DataInheritance:
 Style/DateTime:
   Enabled: true
 
+Style/DigChain:
+  Enabled: true
+
 Style/Dir:
   Enabled: false
 
@@ -539,9 +581,15 @@ Style/FetchEnvVar:
 Style/FileEmpty:
   Enabled: true
 
+Style/FileNull:
+  Enabled: true
+
 Style/FileRead:
   Enabled: false
 
+Style/FileTouch:
+  Enabled: true
+
 Style/FileWrite:
   Enabled: false
 
@@ -552,11 +600,11 @@ Style/FormatStringToken:
   Enabled: false
 
 Style/FrozenStringLiteralComment:
-  SafeAutoCorrect: true
-  EnforcedStyle: always_true
   Details: 'Add `# frozen_string_literal: true` to the top of the file. Frozen string
     literals will become the default in a future Ruby version, and we want to make
     sure we''re ready.'
+  EnforcedStyle: always_true
+  SafeAutoCorrect: true
 
 Style/GuardClause:
   Enabled: false
@@ -576,8 +624,8 @@ Style/HashExcept:
 Style/HashLikeCase:
   Enabled: false
 
-Style/HashSyntax:
-  EnforcedShorthandSyntax: either
+Style/HashSlice:
+  Enabled: true
 
 Style/HashTransformKeys:
   Enabled: false
@@ -600,6 +648,12 @@ Style/InverseMethods:
 Style/InvertibleUnlessCondition:
   Enabled: true
 
+Style/ItAssignment:
+  Enabled: true
+
+Style/KeywordArgumentsMerging:
+  Enabled: true
+
 Style/KeywordParametersOrder:
   Enabled: false
 
@@ -625,14 +679,14 @@ Style/MapToSet:
   Enabled: false
 
 Style/MethodCallWithArgsParentheses:
-  Enabled: true
   AllowedMethods:
   - require
   - require_relative
   - require_dependency
   - yield
   - raise
   - puts
+  Enabled: true
   Exclude:
   - "/**/Gemfile"
 
@@ -762,6 +816,9 @@ Style/RedundantHeredocDelimiterQuotes:
 Style/RedundantInitialize:
   Enabled: false
 
+Style/RedundantInterpolationUnfreeze:
+  Enabled: true
+
 Style/RedundantLineContinuation:
   Enabled: true
 
@@ -807,9 +864,15 @@ Style/ReturnNilInPredicateMethodDefinition:
   Enabled: true
 <% end %>
 
+Style/SafeNavigationChainLength:
+  Enabled: true
+
 Style/SelectByRegexp:
   Enabled: false
 
+Style/SendWithLiteralMethodName:
+  Enabled: true
+
 Style/SingleArgumentDig:
   Enabled: false
 
@@ -842,6 +905,9 @@ Style/StringLiteralsInInterpolation:
 Style/StructInheritance:
   Enabled: false
 
+Style/SuperArguments:
+  Enabled: true
+
 <% if rubocop_version >= "1.58" %>
 Style/SuperWithArgsParentheses:
   Enabled: true