Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] add bigdecimal to gemspec for ruby 3.4 #1882

Closed

Conversation

mathbruyen
Copy link

bigdecimal was removed from stdlib in Ruby 3.4 and liquid fails to be loaded:

0.679 /usr/local/bundle/gems/liquid-4.0.4/lib/liquid/standardfilters.rb:2:in 'Kernel#require': cannot load such file -- bigdecimal (LoadError)                                                                     
0.679   from /usr/local/bundle/gems/liquid-4.0.4/lib/liquid/standardfilters.rb:2:in '<top (required)>'
0.679   from /usr/local/bundle/gems/liquid-4.0.4/lib/liquid.rb:72:in 'Kernel#require'
0.679   from /usr/local/bundle/gems/liquid-4.0.4/lib/liquid.rb:72:in '<top (required)>'
0.679   from /usr/local/bundle/gems/jekyll-4.3.4/lib/jekyll.rb:35:in 'Kernel#require'

Fixes #1772 which also mentions base64, but the later is not directly used by liquid thus not added.

Similar pull request but targeted at main which already has the change (5.x releases have the depenency), can likely be closed: #1779

@ggmichaelgo
Copy link
Contributor

Hello @mathbruyen 👋

Since the Liquid version 4 releases are 3+ years old, we should try to use the latest version of Liquid.

It looks like there is already PR to update Jekyll's Liquid version:
jekyll/jekyll#9722

@mathbruyen
Copy link
Author

Jekyll won't include required dependencies for Ruby 3.4 as a patch release (comment), support will thus land in another major which will (likely) use a more recent version of liquid.

@mathbruyen mathbruyen closed this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants