Update asserted verifier error messages

Shopify · Sep 11, 2024 · c8e3c3f · c8e3c3f
1 parent e6eb592
commit c8e3c3f
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/test/integration/interrupt_resume_test.rb b/test/integration/interrupt_resume_test.rb
@@ -254,8 +254,11 @@ def test_interrupt_resume_inline_verifier_will_verify_entries_in_reverify_store
     assert_equal 1, incorrect_tables.length
     assert_equal "gftest.test_table_1", incorrect_tables.first
 
-    error_line = ghostferry.error_lines.last
-    assert error_line["msg"].start_with?("cutover verification failed for: gftest.test_table_1 [paginationKeys: #{chosen_id}")
+    error_message = ghostferry.error_lines.last["msg"]
+    predicate = "cutover verification failed for: gftest.test_table_1 [PKs: #{chosen_id}"
+    expectation = error_message.start_with?(predicate)
+
+    assert expectation, "error message: #{error_message.inspect}, didn't start with #{predicate.inspect}"
   end
 
   def test_interrupt_resume_inline_verifier_will_verify_additional_rows_changed_on_source_during_interrupt
@@ -299,7 +302,7 @@ def test_interrupt_resume_inline_verifier_will_verify_additional_rows_changed_on
     assert_equal "gftest.test_table_1", incorrect_tables.first
 
     error_message = ghostferry.error_lines.last["msg"]
-    predicate = "cutover verification failed for: gftest.test_table_1 [paginationKeys: #{chosen_id}"
+    predicate = "cutover verification failed for: gftest.test_table_1 [PKs: #{chosen_id}"
     expectation = error_message.start_with?(predicate)
 
     assert expectation, "error message: #{error_message.inspect}, didn't start with #{predicate.inspect}"
@@ -669,6 +672,11 @@ def test_issue_149_corrupted
 
     assert verification_ran
     assert_equal ["#{DEFAULT_DB}.#{DEFAULT_TABLE}"], incorrect_tables
-    assert ghostferry.error_lines.last["msg"].start_with?("cutover verification failed for: gftest.test_table_1 [paginationKeys: #{id_to_change}")
+
+    error_message = ghostferry.error_lines.last["msg"]
+    predicate = "cutover verification failed for: gftest.test_table_1 [PKs: #{id_to_change}"
+    expectation = error_message.start_with?(predicate)
+
+    assert expectation, "error message: #{error_message.inspect}, didn't start with #{predicate.inspect}"
   end
 end