added todo

Shopify · Aug 29, 2024 · 46cd6dc · 46cd6dc
1 parent c85a06c
commit 46cd6dc
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/inline_verifier.go b/inline_verifier.go
@@ -448,6 +448,8 @@ func (v *InlineVerifier) VerifyDuringCutover() (VerificationResult, error) {
 		}, nil
 	}
 
+	// TODO make this into a func:
+	//   func FormatMismatches(mismatches map[string]map[string][]InlineVerifierMismatches)) string
 	// Build error message for display
 	var messageBuf bytes.Buffer
 	messageBuf.WriteString("cutover verification failed for: ")
@@ -465,6 +467,10 @@ func (v *InlineVerifier) VerifyDuringCutover() (VerificationResult, error) {
 				messageBuf.WriteString(mismatch.SourceChecksum)
 				messageBuf.WriteString(", target: ")
 				messageBuf.WriteString(mismatch.TargetChecksum)
+				// TODO add the mismatch details somehow
+				// ([paginationKeys: (source: "..", target: "..")])
+				// to
+				// ([paginationKeys: (source: "..", target: "..", type: "missing on source", column: "")])
 				messageBuf.WriteString(") ")
 			}
 			messageBuf.WriteString("] ")
@@ -476,7 +482,7 @@ func (v *InlineVerifier) VerifyDuringCutover() (VerificationResult, error) {
 
 	return VerificationResult{
 		DataCorrect:     false,
-		Message:         messageBuf.String(),
+		Message:         message,
 		IncorrectTables: incorrectTables,
 	}, nil
 }