Merge pull request #4729 from Shopify/dont-remove-first-class-fields-…

…on-dev-stable [Stable] Fix crash on dev when making changes in an extension
Shopify · Oct 23, 2024 · 728f5b7 · 728f5b7
2 parents 7951b24 + fc58722
commit 728f5b7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/.changeset/famous-pears-type.md b/.changeset/famous-pears-type.md
@@ -0,0 +1,5 @@
+---
+'@shopify/app': patch
+---
+
+Fix issue with dev crashing after making a change in an extension
diff --git a/packages/app/src/cli/services/dev/update-extension.ts b/packages/app/src/cli/services/dev/update-extension.ts
@@ -7,7 +7,6 @@ import {
 } from '../../models/app/loader.js'
 import {ExtensionInstance} from '../../models/extensions/extension-instance.js'
 import {ExtensionsArraySchema, UnifiedSchema} from '../../models/extensions/schemas.js'
-import {configWithoutFirstClassFields} from '../../models/extensions/specification.js'
 import {DeveloperPlatformClient} from '../../utilities/developer-platform-client.js'
 import {themeExtensionConfig} from '../deploy/theme-extension-config.js'
 import {AbortError} from '@shopify/cli-kit/node/error'
@@ -111,8 +110,7 @@ export async function reloadExtensionConfig({extension}: UpdateExtensionConfigOp
       )
     }
 
-    const mergedConfig = {...configuration, ...extensionConfig}
-    configObject = configWithoutFirstClassFields(mergedConfig)
+    configObject = {...configuration, ...extensionConfig}
   }
 
   const newConfig = await parseConfigurationObjectAgainstSpecification(