some visual changes for better visual experience

1. Video Title in Description now shows 2 lines 2. Size of description text under videos increased to 14sp for better visual experience 3. Size of comments in comments section increased to 14sp 4. a visual fixes in background player activity
ShareASmile · Jul 12, 2024 · b962fbe · b962fbe
1 parent adc4421
commit b962fbe
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 22 deletions.
diff --git a/app/src/main/java/org/schabi/newpipelegacy/fragments/detail/VideoDetailFragment.java b/app/src/main/java/org/schabi/newpipelegacy/fragments/detail/VideoDetailFragment.java
@@ -495,7 +495,7 @@ public boolean onLongClick(final View v) {
 
     private void toggleTitleAndDescription() {
         if (videoDescriptionRootLayout.getVisibility() == View.VISIBLE) {
-            videoTitleTextView.setMaxLines(1);
+            videoTitleTextView.setMaxLines(2);
             videoDescriptionRootLayout.setVisibility(View.GONE);
             videoDescriptionView.setFocusable(false);
             videoTitleToggleArrow.setImageResource(
@@ -1149,7 +1149,7 @@ public void showLoading() {
         animateView(positionView, false, 50);
 
         videoTitleTextView.setText(name != null ? name : "");
-        videoTitleTextView.setMaxLines(1);
+        videoTitleTextView.setMaxLines(2);
         animateView(videoTitleTextView, true, 0);
 
         videoDescriptionRootLayout.setVisibility(View.GONE);

diff --git a/app/src/main/res/layout-large-land/fragment_video_detail.xml b/app/src/main/res/layout-large-land/fragment_video_detail.xml
@@ -177,7 +177,7 @@
                         android:layout_marginEnd="30dp"
                         android:layout_marginRight="30dp"
                         android:ellipsize="end"
-                        android:maxLines="1"
+                        android:maxLines="2"
                         android:paddingTop="12dp"
                         android:paddingBottom="8dp"
                         android:textAppearance="?android:attr/textAppearanceLarge"

diff --git a/app/src/main/res/layout/activity_player_queue_control.xml b/app/src/main/res/layout/activity_player_queue_control.xml
@@ -80,25 +80,24 @@
             android:textSize="14sp"
             tools:text="Lorem ipsum dolor sit amet, consectetur adipiscing elit. Duis nec aliquam augue, eget cursus est. Ut id tristique enim, ut scelerisque tellus. Sed ultricies ipsum non mauris ultricies, commodo malesuada velit porta." />
 
-            <TextView
-                android:id="@+id/artist_name"
-                android:layout_width="match_parent"
-                android:layout_height="wrap_content"
-                android:ellipsize="marquee"
-                android:fadingEdge="horizontal"
-                android:marqueeRepeatLimit="marquee_forever"
-                android:scrollHorizontally="true"
-                android:singleLine="true"
-                android:textAppearance="?android:attr/textAppearanceMedium"
-                android:textSize="12sp"
-                tools:text="Duis posuere arcu condimentum lobortis mattis." />
-        </LinearLayout>
+        <TextView
+            android:id="@+id/artist_name"
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            android:ellipsize="marquee"
+            android:fadingEdge="horizontal"
+            android:marqueeRepeatLimit="marquee_forever"
+            android:scrollHorizontally="true"
+            android:singleLine="true"
+            android:textAppearance="?android:attr/textAppearanceMedium"
+            android:textSize="12sp"
+            tools:text="Duis posuere arcu condimentum lobortis mattis." />
+    </LinearLayout>
 
     <LinearLayout
         android:id="@+id/progress_bar"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
-        android:background="@drawable/player_controls_background"
         android:orientation="horizontal"
         android:paddingLeft="12dp"
         android:paddingRight="12dp"

diff --git a/app/src/main/res/layout/fragment_video_detail.xml b/app/src/main/res/layout/fragment_video_detail.xml
@@ -172,7 +172,7 @@
                         android:layout_marginEnd="30dp"
                         android:layout_marginRight="30dp"
                         android:ellipsize="end"
-                        android:maxLines="1"
+                        android:maxLines="2"
                         android:paddingTop="12dp"
                         android:paddingBottom="8dp"
                         android:textAppearance="?android:attr/textAppearanceLarge"

diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml
@@ -56,8 +56,8 @@
     <dimen name="video_item_detail_likes_text_size">12sp</dimen>
     <dimen name="video_item_detail_uploader_text_size">12sp</dimen>
     <dimen name="video_item_detail_sub_channel_text_size">14sp</dimen>
-    <dimen name="video_item_detail_upload_date_text_size">13sp</dimen>
-    <dimen name="video_item_detail_description_text_size">13sp</dimen>
+    <dimen name="video_item_detail_upload_date_text_size">14sp</dimen>
+    <dimen name="video_item_detail_description_text_size">14sp</dimen>
     <dimen name="video_item_detail_next_text_size">15sp</dimen>
     <dimen name="channel_subscribers_text_size">12sp </dimen>
     <dimen name="channel_rss_title_size">12sp</dimen>
@@ -109,8 +109,8 @@
     <dimen name="file_picker_items_text_size">14sp</dimen>
 
     <!-- Text Size -->
-    <dimen name="comment_item_title_text_size">12sp</dimen>
-    <dimen name="comment_item_content_text_size">12sp</dimen>
+    <dimen name="comment_item_title_text_size">14sp</dimen>
+    <dimen name="comment_item_content_text_size">14sp</dimen>
 
     <!-- Feed Groups dimensions-->
     <dimen name="feed_group_carousel_start_end_margin">12dp</dimen>