Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add dynamic path param support #1808

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

KyrillosNageh
Copy link
Contributor

This update enhances the RequestBuilder class by introducing dynamic path parameter substitution. The solution includes:

  1. A method to handle single key-value pairs for setting path parameters dynamically.
  2. A method to handle multiple key-value pairs for scenarios involving complex endpoints.

@KyrillosNageh KyrillosNageh marked this pull request as draft November 18, 2024 10:14
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 52.53%. Comparing base (ce02a45) to head (57cce59).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
src/main/java/com/shaft/api/RequestBuilder.java 66.66% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1808      +/-   ##
============================================
- Coverage     53.24%   52.53%   -0.71%     
- Complexity     1355     1357       +2     
============================================
  Files           113      115       +2     
  Lines         10176    10353     +177     
  Branches        991      998       +7     
============================================
+ Hits           5418     5439      +21     
- Misses         4117     4273     +156     
  Partials        641      641              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant