fix(target): Adjust QAM chord timing #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowApex
approved these changes
Oct 16, 2024
pastaq
approved these changes
Oct 17, 2024
|
🎉 This PR is included in version 0.36.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally, pushing the QAM button may have SteamOS process the emitted Guide and A button outputs in the incorrect order (eg pressing A and then opening the Steam menu). This seems to occur more often on devices that do not support holding the QAM output (such as ROG Ally and MSI Claw).
This changes the Guide button to be held an extra 80ms before emitting A. In my testing I failed to see a single aberrant event once this change was applied. Testing was performed on MSI Claw, Win600, ROG Ally and Ayaneo Air Plus.