Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Touchpad): Add Touchpad to other events translations. #169

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

pastaq
Copy link
Contributor

@pastaq pastaq commented Jul 31, 2024

TODO:

  • Add Touchpad & Touchscreen to mouse translations

@pastaq pastaq force-pushed the pastaq/load_profile_from_json_dbus branch 2 times, most recently from 6a34a09 to 752e96e Compare August 1, 2024 21:16
@pastaq pastaq marked this pull request as ready for review August 1, 2024 21:17
@pastaq pastaq force-pushed the pastaq/load_profile_from_json_dbus branch from 752e96e to 2f55df5 Compare August 1, 2024 23:13
@philmmanjaro
Copy link
Contributor

Testsed 2f55df5 combined with OGUI a21df1a7. seems to work so far.

@pastaq pastaq requested a review from ShadowApex August 4, 2024 18:32
@philmmanjaro
Copy link
Contributor

This needs a rebase on top of a2e1af8

@@ -57,6 +57,7 @@
"deck",
"ds5",
"ds5-edge",
"touchpad",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to add this to the input profile schema

@pastaq pastaq force-pushed the pastaq/load_profile_from_json_dbus branch from 2f55df5 to 5993c82 Compare August 6, 2024 05:08
@pastaq pastaq requested a review from ShadowApex August 6, 2024 05:08
- Adds Touchpad InputEvent translation to other InputEvent translation.
- Adds InputPlumber Touchpad target device.
@pastaq pastaq force-pushed the pastaq/load_profile_from_json_dbus branch from 5993c82 to 8e18b7c Compare August 6, 2024 05:15
@philmmanjaro
Copy link
Contributor

8e18b7c compiled fine as backport on 0.33.1.

@ShadowApex ShadowApex merged commit c0431f3 into main Aug 7, 2024
2 checks passed
@ShadowApex ShadowApex deleted the pastaq/load_profile_from_json_dbus branch August 7, 2024 20:20
Copy link

github-actions bot commented Aug 7, 2024

🎉 This issue has been resolved in version 0.34.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants