Use the Pod watcher to detect the set of remote component replicas. #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spetrovic77
force-pushed
the
routing
branch
3 times, most recently
from
75ee0d3
to
b1e435d
Compare
This change mimics the related change in weaver-kube where the babysitter watches the activated component's pods and returns the replicas therein. The GKE deployer was previously consulting the assigner for an updated set of replicas, which is a complicated flow fraught with possibilities of errors. Moreover, an upcoming weaver change will see weavelets performing health checks themselves, obsoleting the current GKE mechanism which has the assigner performing health checks on the babysitters. TODO: Change the assigner to only manage routing information for routed components.
spetrovic77
added a commit
that referenced
this pull request
Aug 4, 2023
After #90, every babysitter retrieves routing information for non-routed components. This means that the assigner is only consulted to retrieve routing information for routed components.
spetrovic77
added a commit
that referenced
this pull request
Aug 4, 2023
After #90, every babysitter retrieves routing information for non-routed components. This means that the assigner is only consulted to retrieve routing information for routed components.
spetrovic77
added a commit
that referenced
this pull request
Aug 4, 2023
After #90, every babysitter retrieves routing information for non-routed components. This means that the assigner is only consulted to retrieve routing information for routed components.
spetrovic77
added a commit
that referenced
this pull request
Aug 7, 2023
After #90, every babysitter retrieves routing information for non-routed components. This means that the assigner is only consulted to retrieve routing information for routed components.
spetrovic77
added a commit
that referenced
this pull request
Aug 7, 2023
After #90, every babysitter retrieves routing information for non-routed components. This means that the assigner is only consulted to retrieve routing information for routed components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change mimics the related change in weaver-kube where the babysitter watches the activated component's pods and returns the replicas therein. The GKE deployer was previously consulting the assigner for an updated set of replicas, which is a complicated flow fraught with possibilities of errors.
Moreover, an upcoming weaver change will see weavelets performing health checks themselves, obsoleting the current GKE mechanism which has the assigner performing health checks on the babysitters.
TODO: Change the assigner to only manage routing information for routed components.
Other changes: