Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove config from task manager and stop killing it #400

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gabegma
Copy link
Contributor

@gabegma gabegma commented Jan 27, 2023

Resolve #347

Description:

🚧 The app is unstable with the current changes.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@gabegma gabegma self-assigned this Jan 27, 2023
@gabegma gabegma changed the base branch from main to ggm/refactor-artifact-manager April 9, 2023 14:25
@gabegma gabegma force-pushed the ggm/refactor-artifact-manager branch from 4095a73 to 3ecfa72 Compare April 13, 2023 20:58
@gabegma gabegma changed the base branch from ggm/refactor-artifact-manager to ggm/improve-stability-start-up April 13, 2023 21:34
@gabegma gabegma force-pushed the ggm/improve-stability-start-up branch 5 times, most recently from e7045a4 to 1657e0e Compare April 19, 2023 18:52
Base automatically changed from ggm/improve-stability-start-up to main April 19, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor TaskManager so it doesn't use config as an attribute, and doesn't need to be killed.
1 participant