fix: upstream sync #113
fix: upstream sync #113
Conversation
new pricing, ready to be merged when the launchweek day 1 article drops
deploy day 1
--- name: Pull Request about: Submit changes to the project for review and inclusion --- ## Description <!--- Describe the changes introduced by this pull request. --> <!--- Explain what problem it solves or what feature/fix it adds. --> ## Related Issue <!--- If this pull request is related to a specific issue, reference it here using #issue_number. --> <!--- For example, "Fixes #123" or "Addresses #456". --> ## Changes Made <!--- Provide a summary of the changes made in this pull request. --> <!--- Include any relevant technical details or architecture changes. --> - Change 1 - Change 2 - ... ## Testing Performed <!--- Describe the testing that you have performed to validate these changes. --> <!--- Include information about test cases, testing environments, and results. --> - Tested feature X in scenario Y. - Ran unit tests for component Z. - Tested on browsers A, B, and C. - ... ## Checklist <!--- Please check the boxes that apply to this pull request. --> <!--- You can add or remove items as needed. --> - [ ] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [ ] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. ## Additional Notes <!--- Provide any additional context or notes for the reviewers. --> <!--- This might include details about design decisions, potential concerns, or anything else relevant. -->
WalkthroughWalkthroughThe recent updates focus on transitioning from a Product Hunt nomination emphasis to the introduction and enhancement of team functionalities within Documenso. This includes a move towards team-based collaboration features, the introduction of new pricing for teams, and the removal of the early adopters plan in favor of team pricing. These changes reflect a strategic pivot towards better serving collaborative efforts and team management within the platform. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 5
Configuration used: CodeRabbit UI
Files selected for processing (4)
- README.md (1 hunks)
- apps/marketing/content/blog/early-adopters.mdx (1 hunks)
- apps/marketing/content/blog/launch-week-2-day-1.mdx (1 hunks)
- apps/marketing/src/components/(marketing)/pricing-table.tsx (1 hunks)
| muted | ||
| ></video> | ||
|
|
||
| > TLDR; Docucmenso now supports teams that share documents, templates and a team mail address. Early Adopter get UNLIMITED<sup>1</sup> Users. |
There was a problem hiding this comment.
There's a typo in "Docucmenso" which should be corrected to "Documenso".
- > TLDR; Docucmenso now supports teams that share documents, templates and a team mail address. Early Adopter get UNLIMITED<sup>1</sup> Users.
+ > TLDR; Documenso now supports teams that share documents, templates and a team mail address. Early Adopters get UNLIMITED<sup>1</sup> Users.Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| > TLDR; Docucmenso now supports teams that share documents, templates and a team mail address. Early Adopter get UNLIMITED<sup>1</sup> Users. | |
| > TLDR; Documenso now supports teams that share documents, templates and a team mail address. Early Adopters get UNLIMITED<sup>1</sup> Users. |
|
|
||
| ## Kicking off Launch Week II - "Connected" | ||
|
|
||
| The day has come! Roughly 5 months after kicked off our first launch week with open sourcing our design and Malfunction Mania, Launch Week #2 is here 🎉 This Launch Week's theme is "connected", since this is all about connecting humans, machines and documents. |
There was a problem hiding this comment.
The phrase "Roughly 5 months after kicked off our first launch week" is grammatically incorrect. Consider revising for clarity.
- The day has come! Roughly 5 months after kicked off our first launch week with open sourcing our design and Malfunction Mania, Launch Week #2 is here 🎉 This Launch Week's theme is "connected", since this is all about connecting humans, machines and documents.
+ The day has come! Roughly 5 months after we kicked off our first launch week with open sourcing our design and Malfunction Mania, Launch Week #2 is here 🎉 This Launch Week's theme is "connected", since this is all about connecting humans, machines, and documents.Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| The day has come! Roughly 5 months after kicked off our first launch week with open sourcing our design and Malfunction Mania, Launch Week #2 is here 🎉 This Launch Week's theme is "connected", since this is all about connecting humans, machines and documents. | |
| The day has come! Roughly 5 months after we kicked off our first launch week with open sourcing our design and Malfunction Mania, Launch Week #2 is here 🎉 This Launch Week's theme is "connected", since this is all about connecting humans, machines, and documents. |
| - Send unlimited signature requests with unlimited recipients | ||
| - Create, view, edit and sign documents owned by the team | ||
| - Define a dedicated team email, to receive signing requests into a team inbox for the owner to sign | ||
| - Manage team roles: Member (Create+Edit), Managers (+Manage Team Members), Owner (+Transfer Team +Delete Team + Sign Documents sent to team email) |
There was a problem hiding this comment.
The role descriptions in the list could be made clearer by specifying the permissions in a more structured format.
Consider reformatting the list of team roles for better readability and understanding. For example:
- - Manage team roles: Member (Create+Edit), Managers (+Manage Team Members), Owner (+Transfer Team +Delete Team + Sign Documents sent to team email)
+ - Manage team roles with clear permissions:
+ - Member: Can create and edit documents.
+ - Manager: Includes Member permissions, plus manage team members.
+ - Owner: Includes Manager permissions, plus transfer and delete team, and sign documents sent to team email.Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| - Manage team roles: Member (Create+Edit), Managers (+Manage Team Members), Owner (+Transfer Team +Delete Team + Sign Documents sent to team email) | |
| - Manage team roles with clear permissions: | |
| - Member: Can create and edit documents. | |
| - Manager: Includes Member permissions, plus manage team members. | |
| - Owner: Includes Manager permissions, plus transfer and delete team, and sign documents sent to team email. |
| - 5 seats minimum | ||
| - You can add seats dynamically as needed | ||
|
|
||
| This pricing will take effect, as soon as the early adopter seats run out. Want to check out teams: [https://documen.so/teams](https://documen.so/teams). |
There was a problem hiding this comment.
The link provided in the text "Want to check out teams" could potentially lead to confusion if the URL is not clickable or if the user is expected to copy and paste it.
Consider making the URL a clickable link for better user experience.
- This pricing will take effect, as soon as the early adopter seats run out. Want to check out teams: https://documen.so/teams.
+ This pricing will take effect as soon as the early adopter seats run out. Want to check out teams? [Visit our teams page](https://documen.so/teams).Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| This pricing will take effect, as soon as the early adopter seats run out. Want to check out teams: [https://documen.so/teams](https://documen.so/teams). | |
| This pricing will take effect as soon as the early adopter seats run out. Want to check out teams? [Visit our teams page](https://documen.so/teams). |
|
|
||
| We are eager to hear from all teams users how you like this addition and what we can add to make it even better. Connect with us on [Twitter / X](https://twitter.com/eltimuro) (DM open) or [Discord](https://documen.so/discord) if you have any questions or comments! We're always here, and we would love to hear from you :) | ||
|
|
||
| > 🚨 We need you help to help us to make this the biggest launch week yet: <a href="https://twitter.com/intent/tweet?text=It's @Documenso Launch Week Day 1! Teams just dropped. Check it out https://documen.so/day1 🚀"> Support us on Twitter </a> or anywhere to spread awareness for open signing! The best posts will receive merch codes 👀 |
There was a problem hiding this comment.
The call to action for supporting the launch week on Twitter uses an <a> tag directly. Ensure that the link opens in a new tab to keep users on the current page.
- > 🚨 We need you help to help us to make this the biggest launch week yet: <a href="https://twitter.com/intent/tweet?text=It's @Documenso Launch Week Day 1! Teams just dropped. Check it out https://documen.so/day1 🚀"> Support us on Twitter </a> or anywhere to spread awareness for open signing! The best posts will receive merch codes 👀
+ > 🚨 We need your help to make this the biggest launch week yet: <a href="https://twitter.com/intent/tweet?text=It's @Documenso Launch Week Day 1! Teams just dropped. Check it out https://documen.so/day1 🚀" target="_blank"> Support us on Twitter </a> or anywhere to spread awareness for open signing! The best posts will receive merch codes 👀Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| > 🚨 We need you help to help us to make this the biggest launch week yet: <a href="https://twitter.com/intent/tweet?text=It's @Documenso Launch Week Day 1! Teams just dropped. Check it out https://documen.so/day1 🚀"> Support us on Twitter </a> or anywhere to spread awareness for open signing! The best posts will receive merch codes 👀 | |
| > 🚨 We need your help to make this the biggest launch week yet: <a href="https://twitter.com/intent/tweet?text=It's @Documenso Launch Week Day 1! Teams just dropped. Check it out https://documen.so/day1 🚀" target="_blank"> Support us on Twitter </a> or anywhere to spread awareness for open signing! The best posts will receive merch codes 👀 |
## Description This PR introduces the ability to add oneself as a signer by simply clicking a button, rather than filling the details manually. ### "Add Myself" in the document creation flow https://github.com/documenso/documenso/assets/25515812/0de762e3-563a-491f-a742-9078bf1d627d ### "Add Myself" in the document template creation flow https://github.com/documenso/documenso/assets/25515812/775bae01-3f5a-4b24-abbf-a47b14ec594a ## Related Issue Addresses [#113](documenso/backlog-internal#113) ## Changes Made Added a new button that grabs the details of the logged-in user and fills the fields *(email, name, and role)* automatically when clicked. ## Testing Performed Tested the changes locally through the UI. ## Checklist - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced the ability for users to add themselves as signers within documents seamlessly. - **Enhancements** - Improved form handling logic to accommodate new self-signer functionality. - Enhanced user interface elements to support the addition of self as a signer, including a new "Add myself" button and disabling input fields during the process. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Summary by CodeRabbit