Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of Zigbee2Mqtt Assistant #22

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

robertcsakany
Copy link
Collaborator

Adding Web Interface to Zigebee2Mqtt. It getting the data from mqtt, so mqtt support have to be enabled in zigbee2mqtt container.

@krema
Copy link

krema commented Jun 13, 2020

@robertcsakany can you please resolve the merge conflict? It would be good if we could finally merge that into a master.

@Willem-Dekker everything looks good except the merge conflict, doesn't it?

@robertcsakany
Copy link
Collaborator Author

I think its okay. Its very simple container, only MQTT is required,

@Willem-Dekker
Copy link
Collaborator

@robertcsakany is this tested? i cant test is my self since i don't use zigbee

@krema
Copy link

krema commented Jun 15, 2020

I am already using it and can confirm that it works.

@Willem-Dekker
Copy link
Collaborator

@robertcsakany or @krema could you update the documentation as wel so others know how to use it and what it does, you can add a page in the /docs folder

@robertcsakany
Copy link
Collaborator Author

Sure. In the next week I will add some. And yes, its tested. I'm make changes only which I use by daily basis.

@ristomatti
Copy link

I just migrated from gcgarner's repo. It seemed to already have zigbee2mqtt assistant and I was already using it but I see now it's gone after migration. I'd like to know at what point has it disappeared?

@robertcsakany robertcsakany force-pushed the feature/AddZigbee2MqttAssistant branch from 906a0d4 to 46c378d Compare July 9, 2020 23:39
@robertcsakany
Copy link
Collaborator Author

@Willem-Dekker Please check it' I've added some documentation.

@ristomatti
Copy link

Any schedule when this will be merged? I just happen to be on the remote location I'd want to setup IOTstack (incl. Zigbee2MqttAssistant) for today and leaving tomorrow. 🙂

I can of course merge this locally but is there still something missing for this to work properly?

@Slyke
Copy link
Collaborator

Slyke commented Jul 21, 2020

Hey @ristomatti and @robertcsakany , I have put this into the new-menu branch (along with zigbee2mqtt). I'm almost ready to merge it to the experimental branch. For now I left the virtual host setting to use xip.io, but do note that this will change in the future (it will have a configurable option, as this service can be hosted on the RPi, see: #83 )

@Slyke
Copy link
Collaborator

Slyke commented Jul 29, 2020

Hey @ristomatti and @robertcsakany can you please test zigbee2mqtt_assistant and/or zigbee2mqtt (plus any other serives you use) on the experimental branch? Please let me know if you run into any bugs, big or small. I have no way to test that the zigbee services are working correctly with the new menu.
In the project directory you can type the following:

git fetch
git checkout experimental
git pull
./menu.sh

@ristomatti
Copy link

@Slyke I'll try to remember when I'm next time at the install location. Meanwhile I found out though pretty much the same functionality can be achieved within Node-RED using https://flows.nodered.org/node/node-red-contrib-zigbee2mqtt and its bridge node. But maybe zigbee2mqtt assistant is a bit cleaner solution so I'll sure test it.

I was already successfully using it from Graham's repo before I switched over. Are there any significant changes?

@Slyke
Copy link
Collaborator

Slyke commented Jul 30, 2020

@ristomatti Yes! There are a lot of changes! I pretty much rewrote the entire stack from the ground up in Python (due to its popularity and ease of use when interfacing with YAML). I've been testing the new stack on multiple platforms (not just RPis), but some of the hardware specific stuff is difficult to test. Majority of it is done, there may be some small bugs. Ensure you have a working backup - mainly your docker-compose.yml file.

It was written in Python for planned future features (mainly auto-configuration based on selected services and hardware). You'll already see some of them have been completed, like port conflict checking and so on. I'll be starting on the documentation for it once I'm happy everyone else will be happy with it.

If you find any bugs, or even usability issues please let me know. Will attempt to fix.

Edit:

I added "node-red-contrib-zigbee2mqtt" to the list of installable NodeRed modules.

@robertcsakany
Copy link
Collaborator Author

@Slyke What about this PR? Can I merge it?

@ukkopahis
Copy link

Functionality has been added via other commits. This PR should be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants