Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cursor line rendering to the Build Analyzer chart and fixed .env.example #1848

Closed
wants to merge 3 commits into from
Closed

Added cursor line rendering to the Build Analyzer chart and fixed .env.example #1848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c946a06
Added cursor line rendering to the Build Analyzer chart when a data p…
ElementUser Aug 24, 2024
131cc68
Fixed indentation/syntax issues
ElementUser Aug 24, 2024
3790c32
Fixed indentation syntax (uses tabs instead of spaces now)
ElementUser Aug 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ TWITCH_CLIENT_SECRET=
SKALOP_SYSTEM_MESSAGE_URL=http://localhost:5900/system
SKALOP_TOKEN=secret

BASE_URL=https://example.com

VITE_SITE_DOMAIN=http://localhost:5173
VITE_SKALOP_WS_URL=ws://localhost:5900

Expand Down
6 changes: 4 additions & 2 deletions app/components/Chart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export default function Chart({
headerSuffix,
valueSuffix,
xAxis,
renderCursorLines = false,
}: {
options: [
{ label: string; data: Array<{ primary: Date; secondary: number }> },
Expand All @@ -20,6 +21,7 @@ export default function Chart({
headerSuffix?: string;
valueSuffix?: string;
xAxis: "linear" | "localTime";
renderCursorLines?: boolean;
}) {
const { i18n } = useTranslation();
const theme = useTheme();
Expand Down Expand Up @@ -78,8 +80,8 @@ export default function Chart({
/>
),
},
primaryCursor: false,
secondaryCursor: false,
primaryCursor: renderCursorLines,
secondaryCursor: renderCursorLines,
primaryAxis,
secondaryAxes,
dark: theme.htmlThemeClass === Theme.DARK,
Expand Down
1 change: 1 addition & 0 deletions app/features/build-analyzer/routes/analyzer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1025,6 +1025,7 @@ function StatChart({
headerSuffix={t("analyzer:abilityPoints.short")}
valueSuffix={valueSuffix}
xAxis="linear"
renderCursorLines
/>
);
}
Expand Down
Loading