Bug fix - failing CI test (#104)

- Instead of `assertContains` use `assertStringContainsStringIgnoringCase` - Instead of `assertInternalType` use `assertIsArray`
SemanticMediaWiki · Feb 26, 2024 · 7d7b98f · 7d7b98f
1 parent 226144c
commit 7d7b98f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -37,9 +37,9 @@ jobs:
             database_type: mysql
             database_image: "mariadb:latest"
             coverage: false
-            experimental: true
+            experimental: false
           - mediawiki_version: '1.40'
-            smw_version: dev-master
+            smw_version: 'dev-master'
             php_version: 8.1
             database_type: mysql
             database_image: "mariadb:latest"

diff --git a/tests/phpunit/Integration/I18nJsonFileIntegrityTest.php b/tests/phpunit/Integration/I18nJsonFileIntegrityTest.php
@@ -20,8 +20,7 @@ public function testI18NJsonDecodeEncode( $file ) {
 
 		$contents = file_get_contents( $file );
 
-		$this->assertInternalType(
-			'array',
+		$this->assertIsArray(
 			json_decode( $contents, true ),
 			'Failed with ' . $this->getDescriptiveJsonError( json_last_error() ) . ' in ' . $file
 		);

diff --git a/tests/phpunit/Unit/MermaidParserFunctionTest.php b/tests/phpunit/Unit/MermaidParserFunctionTest.php
@@ -66,7 +66,7 @@ public function testParse($text, $expected)
 			$mockExtractor
 		);
 
-		$this->assertContains(
+		$this->assertStringContainsStringIgnoringCase(
 			$expected,
 			$instance->parse($text)
 		);