Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove extra semi colon to fix webpack 5 build issue. #76

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

sahi1422
Copy link
Contributor

@sahi1422 sahi1422 commented Nov 15, 2021

#75

@sahi1422
Copy link
Contributor Author

sahi1422 commented Nov 15, 2021

@jlukic @xiaohanyu @nooitaf @levithomason , can you please have a look at this PR and help me merge it? This is a kind of blocking issue and makes users choose between webpack5 and Semantic UI.

@nooitaf
Copy link
Member

nooitaf commented Nov 15, 2021

LGTM

@Sahil-rll
Copy link

@nooitaf , thanks for having a look. Would you please give some idea how long it can take to get this PR merged?

@levithomason
Copy link
Member

Thanks for the find and fix. I believe this file is generated in a build, possibly from the main repo. I will try to take a look at it soon.

@sahi1422
Copy link
Contributor Author

@levithomason , any updates?

@levithomason levithomason merged commit 01e4a53 into Semantic-Org:master Dec 16, 2021
@sahi1422
Copy link
Contributor Author

@jlukic @levithomason , thanks for looking into this. I see the PR got merged. When will these changes be reflected in the NPM package?

@aruna-x
Copy link

aruna-x commented Dec 16, 2021

I used this package with no issue before today. Unfortunately the recent merge may have cause me and a few of my colleagues to get an error related to the extra semi colon now. (We all started new projects today.)

peacekeeper added a commit to peacekeeper/Fomantic-UI-CSS that referenced this pull request Jan 7, 2022
peacekeeper added a commit to peacekeeper/Fomantic-UI-CSS that referenced this pull request Jan 7, 2022
fniessink added a commit to ICTU/quality-time that referenced this pull request Mar 23, 2022
fniessink added a commit to ICTU/quality-time that referenced this pull request Mar 23, 2022
* Use peacekeeper/Fomantic-UI-CSS@c94ff9b for Fomantic UI CSS because it fixes Semantic-Org/Semantic-UI-CSS#76 which prevents upgrade to Webpack 5.

* Update Create React App to v5.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants