-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual integration to Topic Page Test Branch #2108
Closed
yonadavGit
wants to merge
14
commits into
chore/sc-29905/write-more-playwright-tests-for-topic-pages
from
manual-integration
Closed
Manual integration to Topic Page Test Branch #2108
yonadavGit
wants to merge
14
commits into
chore/sc-29905/write-more-playwright-tests-for-topic-pages
from
manual-integration
Commits on Jul 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3e60399 - Browse repository at this point
Copy the full SHA 3e60399View commit details
Commits on Jul 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 170d3ce - Browse repository at this point
Copy the full SHA 170d3ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for c120aa6 - Browse repository at this point
Copy the full SHA c120aa6View commit details -
Initial Commit of Translation Version Name in Title Bar
Sefaria/Sefaria-Playwright-Tests#18 TODO: Decide if we want to test for default translation title.
Configuration menu - View commit details
-
Copy full SHA for 622d4c7 - Browse repository at this point
Copy the full SHA 622d4c7View commit details
Commits on Jul 25, 2024
-
Testing for default source language only
Issue noted for Hebrew sources - no default translation is selected.
Configuration menu - View commit details
-
Copy full SHA for 353d8e9 - Browse repository at this point
Copy the full SHA 353d8e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for f1136b2 - Browse repository at this point
Copy the full SHA f1136b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0197eed - Browse repository at this point
Copy the full SHA 0197eedView commit details -
Configuration menu - View commit details
-
Copy full SHA for acb07a8 - Browse repository at this point
Copy the full SHA acb07a8View commit details
Commits on Aug 9, 2024
-
Expanding tests to handle bilingual source texts
Also allowing default translation validations to be skipped for Hebrew language source texts
Configuration menu - View commit details
-
Copy full SHA for 018f556 - Browse repository at this point
Copy the full SHA 018f556View commit details
Commits on Aug 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0bb0ec0 - Browse repository at this point
Copy the full SHA 0bb0ec0View commit details
Commits on Sep 30, 2024
-
Solving issue with flakey tests by clearing cookies for each test
Issue: Tests time out on assertions looking for text in the wrong language Solution: Clearing the cookies resets the cookie-setting process and allows language cookies to be refreshed for each context.
Configuration menu - View commit details
-
Copy full SHA for b953eaf - Browse repository at this point
Copy the full SHA b953eafView commit details
Commits on Oct 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e5131aa - Browse repository at this point
Copy the full SHA e5131aaView commit details
Commits on Oct 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7cbe48a - Browse repository at this point
Copy the full SHA 7cbe48aView commit details
Commits on Oct 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fa91c48 - Browse repository at this point
Copy the full SHA fa91c48View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.