Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version with alt title #2076

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Version with alt title #2076

merged 3 commits into from
Oct 28, 2024

Conversation

YishaiGlasner
Copy link
Contributor

Description

Versions should use only primary title of indexes and not alt titles (alts are not unique).

Code Changes

  1. Get the Index from Version by Index().load() rather than library.get_index
  2. When saving version from a csv file, check for index with the primary title (rather than getting it by Ref), and if doesn't exist raise an InputError with clear message.

…g the Index from Version. that prevent Version to have an alternative title, and not the primary title (different indexes can have the same alt title).
…t exist raise Error with a clear message (previously it would have fall without message, or do wierd things).
sefaria/export.py Show resolved Hide resolved
sefaria/export.py Show resolved Hide resolved
yitzhakc
yitzhakc previously approved these changes Oct 27, 2024
@YishaiGlasner YishaiGlasner added this pull request to the merge queue Oct 28, 2024
Merged via the queue into master with commit ec7622c Oct 28, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants