Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sc 29344/sheet header #2068

Open
wants to merge 14 commits into
base: feature/sc-27320/remove-reader-header-bar
Choose a base branch
from

Conversation

stevekaplan123
Copy link
Contributor

Description

This PR creates the new header for the sheet viewer. It displays a title, sheet summary, user profile picture, and user profile name.

Code Changes

  1. Currently, a component called SheetMetaDataBox is used to display metadata for sheets. I re-appropriated this component to use for the header. The advantage of doing this is that its corresponding CSS was easy to find and remove/modify.
  2. I took the component SheetTitle, which was previously used with SheetMetaDataBox, copied and adapted it slightly to display either the title or summary. It's called SheetMetaDataBoxSegment. I wasn't sure if this was a good idea. The advantage of re-using code from SheetTitle is that it will be (a) editable when used for the header of the Sheet Editor, (b) it strips HTML from the text, and (c) displays in the right direction based on the hebrew/english content of its text
  3. The rest of the code of this PR simply removes CSS no longer needed for .sheetMetaDataBox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant