Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sefer hachinukh linker #1948

Merged
merged 19 commits into from
Oct 28, 2024
Merged

Fix sefer hachinukh linker #1948

merged 19 commits into from
Oct 28, 2024

Commits on Jul 1, 2024

  1. fix(linker): update ref for Avot DeRabbi Natan

    @nsantacruz
    nsantacruz committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    5b43cb7 View commit details
    Browse the repository at this point in the history

  2. fix(linker): functional but very messy fix for detecting overlapping … 

    …ResolvedRefs when at least one is mapped to an AltStructNode
    @nsantacruz
    nsantacruz committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    e3b18c0 View commit details
    Browse the repository at this point in the history

  3. fix(schema): handle case where other isn't a schemaNode

    @nsantacruz
    nsantacruz committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    68255a5 View commit details
    Browse the repository at this point in the history

  4. refactor(linker): refactor contains() so that main logic appears in r… 

    …eferenceable_book_node.py
    @nsantacruz
    nsantacruz committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    ddc46c8 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Merge branch 'fix-commentary-amud-linker' into fix-sefer-hachinukh-li… 

    …nker
    @nsantacruz
    nsantacruz committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    0a175f5 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. test(linker): remove broken import

    @nsantacruz
    nsantacruz committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    387605b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix-sefer-hachinukh-linker

    @nsantacruz
    nsantacruz committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    b362fb1 View commit details
    Browse the repository at this point in the history

  3. test(linker): add tests for the new 'contain' implementation of Refer… 

    …enceableBookNode
    @yonadavGit
    yonadavGit committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    da3ca8f View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. fix(linker): add parent to ja node when creating a numberedReferencea… 

    …bleBookNode child

This makes a test past for ReferenceableBookNode.contains() in a case that may not come up in production but is possible to happen based on the function's contract.
    @nsantacruz
    nsantacruz committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    c1d9435 View commit details
    Browse the repository at this point in the history

  2. test(linker): add more tests for ReferenceableBookNode.contains()

    @nsantacruz
    nsantacruz committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    5912b30 View commit details
    Browse the repository at this point in the history

  3. docs(linker): explain ReferenceableBookNode.contains() a bit more

    @nsantacruz
    nsantacruz committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    4dcc731 View commit details
    Browse the repository at this point in the history

  4. fix(linker): use default value for sort when ref is none

    @nsantacruz
    nsantacruz committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    e9d4750 View commit details
    Browse the repository at this point in the history

  5. fix(linker): dont call get_possible_subrefs if node isn't NumberedRef… 

    …erenceableBookNode
    @nsantacruz
    nsantacruz committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    4ce78b9 View commit details
    Browse the repository at this point in the history

  6. fix(linker): dont include ambiguous resolved refs in list of titles t… 

    …o consider
    @nsantacruz
    nsantacruz committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    1de1a18 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2024

  1. test(linker): add test zohar altStruct test

    @yonadavGit
    yonadavGit committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    dcd8bfc View commit details
    Browse the repository at this point in the history

  2. fix(linker): abstract function leaf_refs() so it can make sense for M… 

    …ap nodes
    @nsantacruz
    nsantacruz committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    ff0eee5 View commit details
    Browse the repository at this point in the history

  3. fix(linker): add IndexNodeReferenceableBookNode to combine all aspect… 

    …s shared between Named Numbered and Map nodes
    @nsantacruz
    nsantacruz committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    49184ad View commit details
    Browse the repository at this point in the history

  4. refactor(linker): move contains into ResolvedRef where it fits more n… 

    …aturally
    @nsantacruz
    nsantacruz committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    170d9df View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. refactor(linker): refactor resolved ref tests to use ResolvedRef obje… 

    …cts instead of ReferenceableBookNodes
    @nsantacruz
    nsantacruz committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    5b82e4b View commit details
    Browse the repository at this point in the history