Sidebar Footer #1946
Merged
Sidebar Footer #1946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edamboritz
approved these changes
Jul 2, 2024
edamboritz
previously approved these changes
Jul 2, 2024
There was a problem hiding this comment.
We need to have a mechanic whereby the footer is included automatically everywhere its needed.
This means either including it in the bottom of the NavSidebar render or designing a new interim component that sits between NavSidebar and the modules that can be used for all the templates where there is a footer expected.
edamboritz
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First pass at design and implementation for the new sidebar footer. The "stickiness" will be addressed in a separate PR.
File Changes
s2.css- Styling for thefooterContainerflex container, and the links inside.static/js/NavSidebar.jsx- Adding a function to return the data, and a functional component to weave into the sidebar for the footer.static/js/TextsPage.jsx- Incorporating the footer module.Notes: