Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop unneccessary duplicate string registrations #428

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Drop unneccessary duplicate string registrations #428

wants to merge 1 commit into from

Conversation

dkg
Copy link
Contributor

@dkg dkg commented Feb 5, 2023 •
edited
Loading

(these were introduced accidentally when @KOLANICH removed the six module in a23dcce)

@dkg
Drop unneccessary duplicate string registrations
2a37a53 
(these were introduced accidentally when KOLANICH removed the six
module in a23dcce)
@dkg
Copy link
Contributor Author

dkg commented May 3, 2023

I've just rebased this onto master. it's non-substantive and should not be particularly challenging or controversial. if it's problematic, i'd be happy to get feedback about what's wrong with it.

@ktdreyer
Copy link

LGTM

@dkg dkg mentioned this pull request Jun 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KOLANICH KOLANICH KOLANICH approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkg @ktdreyer @KOLANICH